r88510 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88509‎ | r88510 | r88511 >
Date:09:27, 21 May 2011
Author:hashar
Status:deferred
Tags:
Comment:
qunit: add some tests for getActionFrom / getTitleFrom

fu r88276
Modified paths:
  • /trunk/phase3/tests/qunit/suites/resources/mediawiki.util/mediawiki.util.js (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/qunit/suites/resources/mediawiki.util/mediawiki.util.js
@@ -83,6 +83,7 @@
8484 'edit': '/edit/$1'
8585 });
8686
 87+ equal( mw.util.getActionFrom( urlB ), 'edit', 'action-parameter support with action path' );
8788 equal( mw.util.getActionFrom( urlC ), 'edit', 'wgActionPaths support' );
8889
8990 // Default settings
@@ -90,6 +91,7 @@
9192 'wgActionPaths': [],
9293 'wgArticlePath': '/w/index.php/$1'
9394 });
 95+ equal( mw.util.getActionFrom( urlB ), 'edit', 'action-parameter support with default settings' );
9496 equal( mw.util.getActionFrom( urlD ), 'view', 'wgArticlePath (/index.php/$1) support' );
9597
9698 });
@@ -109,14 +111,15 @@
110112 });
111113
112114 equal( mw.util.getTitleFrom( urlA ), 'Article', 'wgArticlePath (/wiki/$1) support' );
113 - equal( mw.util.getTitleFrom( urlB ), 'Article', 'action-parameter support' );
 115+ equal( mw.util.getTitleFrom( urlB ), 'Article', 'title-parameter support' );
114116
115117 // Custom settings
116118 mw.config.set( 'wgActionPaths', {
117119 'view': '/view/$1',
118120 'edit': '/edit/$1'
119121 });
120 -
 122+
 123+ equal( mw.util.getTitleFrom( urlB ), 'Article', 'title-parameter support with action path' );
121124 equal( mw.util.getTitleFrom( urlC ), 'Article', 'wgActionPaths support' );
122125
123126 // Default settings
@@ -125,6 +128,7 @@
126129 'wgArticlePath': '/w/index.php/$1'
127130 });
128131
 132+ equal( mw.util.getTitleFrom( urlB ), 'Article', 'title-parameter support with default settings' );
129133 equal( mw.util.getTitleFrom( urlD ), 'Article', 'wgArticlePath (/index.php/$1) support' );
130134
131135 });

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88276mw.util.getActionFrom incorrectly returns null...krinkle22:51, 16 May 2011

Status & tagging log