r88481 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88480‎ | r88481 | r88482 >
Date:19:31, 20 May 2011
Author:siebrand
Status:ok
Tags:
Comment:
Tweak 'config-mysql-myisam-dep' (added in r88475).
Modified paths:
  • /trunk/phase3/includes/installer/Installer.i18n.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/Installer.i18n.php
@@ -317,15 +317,13 @@
318318 'config-mysql-engine' => 'Storage engine:',
319319 'config-mysql-innodb' => 'InnoDB',
320320 'config-mysql-myisam' => 'MyISAM',
321 - 'config-mysql-myisam-dep' => "'''Warning''': You have selected MyISAM. MyISAM is not recommended for use with MediaWiki, because:
 321+ 'config-mysql-myisam-dep' => "'''Warning''': You have selected MyISAM as storage engine for MySQL, which is not recommended for use with MediaWiki, because:
322322 * it barely supports concurrency due to table locking
323323 * it is more prone to corruption than other engines
324324 * the MediaWiki codebase does not always handle MyISAM as it should
325 -* probably other reasons...
326325
327326 If your MySQL installation supports InnoDB, it is highly recommended that you choose that instead.
328 -If your MySQL installation does not support InnoDB, maybe its time for an upgrade.
329 -",
 327+If your MySQL installation does not support InnoDB, maybe its time for an upgrade.",
330328 'config-mysql-engine-help' => "'''InnoDB''' is almost always the best option, since it has good concurrency support.
331329
332330 '''MyISAM''' may be faster in single-user or read-only installations.

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88475Patch for Bug #28669, “Scream bloody murder when user chooses MyISAM and In...mah18:26, 20 May 2011

Status & tagging log