r88474 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88473‎ | r88474 | r88475 >
Date:18:20, 20 May 2011
Author:yaron
Status:deferred
Tags:
Comment:
Removed support for SMW < 1.5.2
Modified paths:
  • /trunk/extensions/SemanticInternalObjects/SemanticInternalObjects_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticInternalObjects/SemanticInternalObjects_body.php
@@ -161,22 +161,11 @@
162162 foreach ( $internalObject->getPropertyValuePairs() as $propertyValuePair ) {
163163 list( $property, $value ) = $propertyValuePair;
164164
165 - // handling changed in SMW 1.5
166 - $realFunction = array( 'SMWSQLStore2', 'findPropertyTableID' );
167 - if ( is_callable( $realFunction ) ) {
168 - $tableid = SMWSQLStore2::findPropertyTableID( $property );
169 - $isRelation = ( $tableid == 'smw_rels2' );
170 - $isAttribute = ( $tableid == 'smw_atts2' );
171 - $isText = ( $tableid == 'smw_text2' );
172 - // new with SMW 1.5.1 / SM 0.6
173 - $isCoords = ( $tableid == 'smw_coords' );
174 - } else {
175 - $mode = SMWSQLStore2::getStorageMode( $property->getPropertyTypeID() );
176 - $isRelation = ( $mode == SMW_SQL2_RELS2 );
177 - $isAttribute = ( $mode == SMW_SQL2_ATTS2 );
178 - $isText = ( $mode == SMW_SQL2_TEXT2 );
179 - $isCoords = false;
180 - }
 165+ $tableid = SMWSQLStore2::findPropertyTableID( $property );
 166+ $isRelation = ( $tableid == 'smw_rels2' );
 167+ $isAttribute = ( $tableid == 'smw_atts2' );
 168+ $isText = ( $tableid == 'smw_text2' );
 169+ $isCoords = ( $tableid == 'smw_coords' );
181170
182171 if ( $isRelation ) {
183172 $upRels2[] = array(

Status & tagging log