r88464 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88463‎ | r88464 | r88465 >
Date:17:03, 20 May 2011
Author:jeroendedauw
Status:ok
Tags:
Comment:
added docs and rem dead code
Modified paths:
  • /trunk/extensions/SemanticWatchlist/includes/SWL_Group.php (modified) (history)
  • /trunk/extensions/SemanticWatchlist/includes/SWL_Groups.php (modified) (history)
  • /trunk/extensions/SemanticWatchlist/specials/SpecialWatchlistConditions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticWatchlist/specials/SpecialWatchlistConditions.php
@@ -120,8 +120,8 @@
121121 }
122122
123123 /**
 124+ * Creates and returns the HTML for a single watchlist group.
124125 *
125 - *
126126 * @since 0.1
127127 *
128128 * @param SWLGroup $group
Index: trunk/extensions/SemanticWatchlist/includes/SWL_Group.php
@@ -13,18 +13,70 @@
1414 */
1515 class SWLGroup {
1616
 17+ /**
 18+ * The ID of the group; the group_id field in swl_groups.
 19+ * When creating a new group, this will be null, and
 20+ * automatically set after writing the group to the DB.
 21+ *
 22+ * @since 0.1
 23+ *
 24+ * @var integer or null
 25+ */
1726 protected $id;
1827
 28+ /**
 29+ * Name of the group.
 30+ *
 31+ * @since 0.1
 32+ *
 33+ * @var string
 34+ */
1935 protected $name;
2036
 37+ /**
 38+ * List of categories this group covers.
 39+ *
 40+ * @since 0.1
 41+ *
 42+ * @var array of string
 43+ */
2144 protected $categories;
2245
 46+ /**
 47+ * List of namespaces IDs of namespaces this group covers.
 48+ *
 49+ * @since 0.1
 50+ *
 51+ * @var array of integer
 52+ */
2353 protected $namespaces = array();
2454
 55+ /**
 56+ * List of SMW properties this group covers.
 57+ *
 58+ * @since 0.1
 59+ *
 60+ * @var array of string
 61+ */
2562 protected $properties;
2663
 64+ /**
 65+ * List of SMW concepts this group covers.
 66+ *
 67+ * @since 0.1
 68+ *
 69+ * @var array of string
 70+ */
2771 protected $concepts;
2872
 73+ /**
 74+ * Cached list of IDs of users that are watching this group,
 75+ * or false if this data has not been obtained yet.
 76+ *
 77+ * @since 0.1
 78+ *
 79+ * @var array of integer or false
 80+ */
2981 protected $watchingUsers = false;
3082
3183 /**
@@ -52,7 +104,7 @@
53105 *
54106 * @since 0.1
55107 *
56 - * @param integer $id Can be null for new groups
 108+ * @param integer $id Set to null when creating a new group.
57109 * @param string $name
58110 * @param array $categories List of category names
59111 * @param array $namespaces List of namespace names or IDs
Index: trunk/extensions/SemanticWatchlist/includes/SWL_Groups.php
@@ -110,23 +110,5 @@
111111 }
112112 }
113113 }
114 -
115 - /**
116 - * Determines and returns if a certain user should be notified of changes
117 - * or not (in case this already happened, so this extension doesn't spam).
118 - *
119 - * @since 0.1
120 - *
121 - * @param integer $userId
122 - *
123 - * @return boolean
124 - */
125 - protected static function userShouldBeNotified( $userId ) {
126 -
127 - }
128 -
129 - protected static function notifyUserOfChangesToGroup( $userId, $group, SMWSemanticData $data ) {
130 -
131 - }
132114
133115 }

Status & tagging log