r88462 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r88461‎ | r88462 | r88463 >
Date:16:39, 20 May 2011
Author:catrope
Status:ok
Tags:
Comment:
ClickTracking: Remove useless index on session_id (is an initial prefix of the UNIQUE KEY below), and add an index for querying property names and values across users
Modified paths:
  • /trunk/extensions/ClickTracking/patches/ClickTrackingUserProperties.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/ClickTracking/patches/ClickTrackingUserProperties.sql
——@@ -18,6 +18,6 @@
1919
2020 ) /*$wgDBTableOptions*/;
2121
22 -CREATE INDEX /*i*/click_tracking_user_properties_session_idx ON /*_*/click_tracking_user_properties (session_id);
 22+CREATE INDEX /*i*/ct_version_name_value ON /*_*/click_tracking_user_properties(property_version, property_name, property_value);
2323
2424 CREATE UNIQUE INDEX ct_user_prop_id_name_value_version ON /*_*/click_tracking_user_properties(session_id, property_name, property_value, property_version);
\ No newline at end of file

Status & tagging log