r88460 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88459‎ | r88460 | r88461 >
Date:15:55, 20 May 2011
Author:yaron
Status:deferred
Tags:
Comment:
Removed setting of height and width for 'free text' textarea - that's handled by the form input
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormPrinter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormPrinter.php
@@ -823,10 +823,6 @@
824824 if ( $is_hidden ) {
825825 $new_text = SFFormUtils::hiddenFieldHTML( 'free_text', '!free_text!' );
826826 } else {
827 - if ( ! array_key_exists( 'rows', $field_args ) )
828 - $field_args['rows'] = 5;
829 - if ( ! array_key_exists( 'cols', $field_args ) )
830 - $field_args['cols'] = 80;
831827 $sfgTabIndex++;
832828 $sfgFieldNum++;
833829 if ( $cur_value == '' ) {
@@ -1414,13 +1410,14 @@
14151411 $form_page_title = null;
14161412 }
14171413
1418 - // If the form has already been submitted, i.e. this is just the redirect
1419 - // page, get rid of all the Javascript, to avoid JS errors.
 1414+ // If the form has already been submitted, i.e. this is just
 1415+ // the redirect page, get rid of all the Javascript, to avoid
 1416+ // JS errors.
14201417 if ( $form_submitted ) {
14211418 $javascript_text = '';
14221419 }
14231420
1424 - $wgOut -> addParserOutputNoText( $parser->getOutput() );
 1421+ $wgOut->addParserOutputNoText( $parser->getOutput() );
14251422
14261423 wfProfileOut( __METHOD__ );
14271424