r88453 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88452‎ | r88453 | r88454 >
Date:15:20, 20 May 2011
Author:ashley
Status:deferred
Tags:
Comment:
WikiForum: remove four unused messages and some dead code related to them; in the original WikiForum, site administrators could choose whether to use pretty icons or plain text. I removed that configuration option as I thought it was silly, but I forgot to remove these messages.
Modified paths:
  • /trunk/extensions/WikiForum/WikiForum.i18n.php (modified) (history)
  • /trunk/extensions/WikiForum/WikiForumClass.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiForum/WikiForum.i18n.php
@@ -65,11 +65,6 @@
6666 'wikiforum-thread-title' => 'Title of your thread',
6767 'wikiforum-no-threads' => 'No threads are available at the moment.',
6868
69 - 'wikiforum-edit' => 'edit',
70 - 'wikiforum-close' => 'close',
71 - 'wikiforum-delete' => 'delete',
72 - 'wikiforum-reopen' => 'reopen',
73 -
7469 'wikiforum-posted' => 'Posted at $1 by $2',
7570 'wikiforum-edited' => 'Edited at $1 by $2',
7671 'wikiforum-closed-text' => 'Thread was closed at $1 by $2',
Index: trunk/extensions/WikiForum/WikiForumClass.php
@@ -2248,18 +2248,10 @@
22492249
22502250 // For grep: wikiforum-edit-forum, wikiforum-edit-category,
22512251 // wikiforum-delete-forum, wikiforum-delete-category
2252 - //if( $wikiconf['icon_' . $type . '_edit'] ) {
22532252 $icon = '<img src="' . $wgScriptPath . '/extensions/WikiForum/icons/' . $iconName . '_edit.png" title="' . wfMsg( 'wikiforum-edit-' . $type ) . '" />';
2254 - //} else {
2255 - // $icon = '<span class="small">' . wfMsg( 'wikiforum-edit' ) . '</span>';
2256 - //}
22572253 $link = ' <a href="' . $specialPage->escapeFullURL( array( 'edit' . $type => $id ) ) . '">' . $icon . '</a>';
22582254
2259 - //if( $wikiconf['icon_' . $type . '_delete'] ) {
22602255 $icon = '<img src="' . $wgScriptPath . '/extensions/WikiForum/icons/' . $iconName . '_delete.png" title="' . wfMsg( 'wikiforum-delete-' . $type ) . '" />';
2261 - //} else {
2262 - // $icon = '<span class="small">' . wfMsg( 'wikiforum-delete' ) . '</span>';
2263 - //}
22642256 $link .= ' <a href="' . $specialPage->escapeFullURL( array( 'delete' . $type => $id ) ) . '">' . $icon . '</a>';
22652257
22662258 if( $sortup == true ) {

Status & tagging log