r88436 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88435‎ | r88436 | r88437 >
Date:22:50, 19 May 2011
Author:wikinaut
Status:deferred
Tags:
Comment:
harmonising page permission check to standards
Modified paths:
  • /trunk/extensions/OpenID/OpenID.setup.php (modified) (history)
  • /trunk/extensions/OpenID/SpecialOpenIDDashboard.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenID/OpenID.setup.php
@@ -27,7 +27,7 @@
2828 exit( 1 );
2929 }
3030
31 -define( 'MEDIAWIKI_OPENID_VERSION', '0.922-beta' );
 31+define( 'MEDIAWIKI_OPENID_VERSION', '0.923-beta' );
3232
3333 # CONFIGURATION VARIABLES
3434
Index: trunk/extensions/OpenID/SpecialOpenIDDashboard.body.php
@@ -61,10 +61,10 @@
6262 global $wgOpenIDAllowServingOpenIDUserAccounts;
6363 global $wgOpenIDShowProviderIcons;
6464
65 - if ( !$wgUser->isAllowed( 'openid-dashboard-access' ) ) {
66 - $wgOut->permissionRequired( 'openid' );
67 - return;
68 - }
 65+ if ( !$this->userCanExecute($wgUser) ) {
 66+ $this->displayRestrictionError();
 67+ return;
 68+ }
6969
7070 $out = "<table class='openiddashboard wikitable'><tr><th>Parameter</th><th>Value</th></tr>";
7171 $out .= show( 'MEDIAWIKI_OPENID_VERSION', MEDIAWIKI_OPENID_VERSION );

Status & tagging log