r88409 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88408‎ | r88409 | r88410 >
Date:15:11, 19 May 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
follow up to r88374, added message docs and split date/time as per request by nikerabbit
Modified paths:
  • /trunk/extensions/SemanticWatchlist/SemanticWatchlist.i18n.php (modified) (history)
  • /trunk/extensions/SemanticWatchlist/includes/SWL_Emailer.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticWatchlist/includes/SWL_Emailer.php
@@ -26,13 +26,16 @@
2727 * @return Status
2828 */
2929 public static function notifyUser( SWLGroup $group, User $user, SWLChangeSet $changeSet, $describeChanges ) {
 30+ global $wgLang;
 31+
3032 $emailText = wfMsgExt(
3133 'swl-email-propschanged-long',
3234 'parse',
3335 $GLOBALS['wgSitename'],
3436 $changeSet->getUser()->getName(),
3537 SpecialPage::getTitleFor( 'SemanticWatchlist' )->getFullURL(),
36 - $GLOBALS['wgLang']->timeanddate( $changeSet->getTime() )
 38+ $wgLang->time( $changeSet->getTime() ),
 39+ $wgLang->date( $changeSet->getTime() )
3740 );
3841
3942 if ( $describeChanges ) {
Index: trunk/extensions/SemanticWatchlist/SemanticWatchlist.i18n.php
@@ -46,7 +46,7 @@
4747
4848 // Email
4949 'swl-email-propschanged' => 'Properties have changed at $1',
50 - 'swl-email-propschanged-long' => "One or more properties you watch at '''$1''' have been changed by user '''$2''' at $4. You can view these and other changes on [$3 your semantic watchlist].",
 50+ 'swl-email-propschanged-long' => "One or more properties you watch at '''$1''' have been changed by user '''$2''' at $4 on $5. You can view these and other changes on [$3 your semantic watchlist].",
5151 'swl-email-changes' => 'Property changes on [$2 $1]:',
5252
5353 // Preferences
@@ -59,6 +59,16 @@
6060 'swl-prefs-emailnofity' => 'E-mail me on changes to properties I am watching',
6161 );
6262
 63+/** Message documentation (Message documentation)
 64+ * @author Jeroen De Dauw
 65+ */
 66+$messages['qqq'] = array(
 67+ 'semanticwatchlist-desc' => '{{desc}}',
 68+ 'right-semanticwatch' => '{{doc-right|semanticwatch}}',
 69+ 'right-semanticwatchgroups' => '{{doc-right|semanticwatchgroups}}',
 70+ 'swl-email-propschanged-long' => '$1: wiki name, $2: user name, $3: url, $4: time, $5: date',
 71+);
 72+
6373 /** German (Deutsch)
6474 * @author Kghbln
6575 * @author Purodha

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88374work on email stuffjeroendedauw17:40, 18 May 2011

Status & tagging log