r88393 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88392‎ | r88393 | r88394 >
Date:20:33, 18 May 2011
Author:hashar
Status:ok
Tags:
Comment:
use string as callback when possible (since PHP 5.2.3)
Modified paths:
  • /trunk/phase3/includes/Hooks.php (modified) (history)
  • /trunk/phase3/includes/UserMailer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/UserMailer.php
@@ -219,7 +219,7 @@
220220 self::$mErrorString = '';
221221 $html_errors = ini_get( 'html_errors' );
222222 ini_set( 'html_errors', '0' );
223 - set_error_handler( array( 'UserMailer', 'errorHandler' ) );
 223+ set_error_handler( 'UserMailer::errorHandler' );
224224
225225 if ( !is_array( $to ) ) {
226226 $to = array( $to );
Index: trunk/phase3/includes/Hooks.php
@@ -229,7 +229,7 @@
230230 * problem here.
231231 */
232232 $retval = null;
233 - set_error_handler( array( 'Hooks', 'hookErrorHandler' ) );
 233+ set_error_handler( 'Hooks::hookErrorHandler' );
234234 wfProfileIn( $func );
235235 try {
236236 $retval = call_user_func_array( $callback, $hook_args );

Status & tagging log