r88371 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88370‎ | r88371 | r88372 >
Date:17:01, 18 May 2011
Author:jeroendedauw
Status:deferred (Comments)
Tags:
Comment:
follow up to r87894
Modified paths:
  • /trunk/extensions/SemanticWatchlist/SemanticWatchlist.i18n.php (modified) (history)
  • /trunk/extensions/SemanticWatchlist/specials/jquery.watchlistcondition.js (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticWatchlist/specials/jquery.watchlistcondition.js
@@ -33,7 +33,7 @@
3434 'value': group.name,
3535 'size': 30
3636 } );
37 - var nameTd = $( '<td />' ).html( $( '<p />' ).text( mediaWiki.msg( 'swl-group-name' ) ).append( nameInput ) );
 37+ var nameTd = $( '<td />' ).html( $( '<p />' ).text( mediaWiki.msg( 'swl-group-name' ) + ' ' ).append( nameInput ) );
3838 table.append( $( '<tr />' ).html( nameTd ) );
3939
4040 var conditionNameInput = $( '<input />' ).attr( {
@@ -41,7 +41,7 @@
4242 'value': group.name,
4343 'size': 30
4444 } );
45 - var conditionTd = $( '<td />' ).html( $( '<p />' ).text( mediaWiki.msg( 'swl-group-page-selection' ) ).append( conditionNameInput ) );
 45+ var conditionTd = $( '<td />' ).html( $( '<p />' ).text( mediaWiki.msg( 'swl-group-page-selection' ) + ' ' ).append( conditionNameInput ) );
4646 table.append( $( '<tr />' ).html( conditionTd ) );
4747
4848 this.append( table );
Index: trunk/extensions/SemanticWatchlist/SemanticWatchlist.i18n.php
@@ -27,10 +27,10 @@
2828 'special-watchlistconditions' => 'Semantic watchlist conditions',
2929
3030 // Special:WatchlistConditions
31 - 'swl-group-name' => 'Group name: ',
 31+ 'swl-group-name' => 'Group name:',
3232 'swl-group-properties' => 'Properties covered by this group:',
3333 'swl-group-remove-property' => 'Remove property',
34 - 'swl-group-page-selection' => 'Pages in ',
 34+ 'swl-group-page-selection' => 'Pages in',
3535
3636 // Special:SemanticWatchlist
3737 'swl-watchlist-position' => "Showing '''$1''' of the last changes starting with '''#$2'''.",

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87894some changes of 2 days back that I apparently did not commit correctlyjeroendedauw22:42, 11 May 2011

Comments

#Comment by Nikerabbit (talk | contribs)   08:17, 19 May 2011

Do you know that you can pass parameters in JS too? ResourceLoader/Migration_guide_for_extension_developers#Internationalization

Status & tagging log