r88329 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88328‎ | r88329 | r88330 >
Date:17:20, 17 May 2011
Author:krinkle
Status:ok
Tags:
Comment:
Passing module to handlePending (bug 28998; Follow-up r88053)
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.js
@@ -489,7 +489,7 @@
490490 addScript( script[i], function() {
491491 if ( ++done == script.length ) {
492492 registry[module].state = 'ready';
493 - handlePending();
 493+ handlePending( module );
494494 if ( $.isFunction( callback ) ) {
495495 callback();
496496 }
@@ -499,7 +499,7 @@
500500 } else if ( $.isFunction( script ) ) {
501501 script( jQuery );
502502 registry[module].state = 'ready';
503 - handlePending();
 503+ handlePending( module );
504504 if ( $.isFunction( callback ) ) {
505505 callback();
506506 }
@@ -520,7 +520,7 @@
521521 *
522522 * This is used when dependencies are satisfied, such as when a module is executed.
523523 */
524 - function handlePending() {
 524+ function handlePending( module ) {
525525 try {
526526 // Run jobs who's dependencies have just been met
527527 for ( var j = 0; j < jobs.length; j++ ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88053Added direct file loading functionality to debug mode for both scripts and st...tparscal12:15, 14 May 2011

Status & tagging log