r88288 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88287‎ | r88288 | r88289 >
Date:08:18, 17 May 2011
Author:dale
Status:deferred (Comments)
Tags:
Comment:
set the default size on the audio player to 23px high ( bug 28973 )
Modified paths:
  • /trunk/extensions/TimedMediaHandler/TimedMediaTransformOutput.php (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/TimedMediaTransformOutput.php
@@ -52,8 +52,8 @@
5353 if ( $this->isVideo ) {
5454 return intval( $this->height );
5555 } else {
56 - // Give sound files a height of 20px
57 - return 20;
 56+ // Give sound files a height of 23px
 57+ return 23;
5858 }
5959 }
6060 function getPlayerWidth(){
@@ -61,7 +61,7 @@
6262 if ( $this->isVideo ) {
6363 return intval( $this->width );
6464 } else {
65 - // Give sound files a height of 20px
 65+ // Give sound files a width of 220px
6666 return 220;
6767 }
6868 }

Comments

#Comment by Nikerabbit (talk | contribs)   10:30, 17 May 2011
-			// Give sound files a height of 20px 
+			// Give sound files a width of 220px 
 			return 220;

The number is right there, why does it need to be repeated in comments?

Status & tagging log