r88280 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88279‎ | r88280 | r88281 >
Date:23:36, 16 May 2011
Author:siebrand
Status:ok
Tags:
Comment:
(bug 28992) Revision numbers in the patrol log are transformed in the user language.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/PatrolLog.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -7,7 +7,7 @@
88
99 THIS IS NOT A RELEASE YET
1010
11 -MediaWiki 1.19 is an alpha-quality branch and is not recommended for use in
 11+MediaWiki 1.19 is an alpha-quality branch and is not recommended for use in
1212 production.
1313
1414 === Configuration changes in 1.19 ===
@@ -25,8 +25,8 @@
2626 * (bug 28503) Support for ircs:// URL protocols
2727 * (bug 26033) It is now possible to count all non-redirect pages in content
2828 namespaces as articles
29 -* Images can now be embedded in an XML dump stream using backupDump.php
30 - --include-files and can be imported using importDump.php --uploads;
 29+* Images can now be embedded in an XML dump stream using backupDump.php
 30+ --include-files and can be imported using importDump.php --uploads;
3131 furthermore, it can import files from the filesystem using --image-base-path
3232 * Three new hooks in Special:Undelete, 'UndeleteForm::showHistory',
3333 'UndeleteForm::showRevision' and 'UndeleteForm::undelete', so that extensions
@@ -56,7 +56,10 @@
5757 * (bug 1780) Uploading files with non-ascii characters are now forbidden on
5858 Windows.
5959 * (bug 23464) File: prefixes are now chopped off during uploading.
60 -* (bug 28174) Message config-logo-help amended to not explicitly assume any LTR/RTL screen layout.
 60+* (bug 28174) Message config-logo-help amended to not explicitly assume any
 61+ LTR/RTL screen layout.
 62+* (bug 28992) Revision numbers in the patrol log are transformed in the user
 63+ language.
6164
6265 === API changes in 1.19 ===
6366 * (bug 27790) add query type for querymodules to action=paraminfo
@@ -75,7 +78,7 @@
7679
7780 MediaWiki 1.19 requires PHP 5.2.3. PHP 4 is no longer supported.
7881
79 -MySQL is the recommended DBMS. PostgreSQL or SQLite can also be used, but
 82+MySQL is the recommended DBMS. PostgreSQL or SQLite can also be used, but
8083 support for them is somewhat less mature. There is experimental support for IBM
8184 DB2, Oracle and Microsoft SQL Server.
8285
@@ -90,8 +93,8 @@
9194 1.19 has several database changes since 1.17, and will not work without schema
9295 updates.
9396
94 -If upgrading from before 1.11, and you are using a wiki as a commons
95 -repository, make sure that it is updated as well. Otherwise, errors may arise
 97+If upgrading from before 1.11, and you are using a wiki as a commons
 98+repository, make sure that it is updated as well. Otherwise, errors may arise
9699 due to database schema changes.
97100
98101 If upgrading from before 1.7, you may want to run refreshLinks.php to ensure
@@ -107,8 +110,8 @@
108111
109112 == Online documentation ==
110113
111 -Documentation for both end-users and site administrators is available on
112 -MediaWiki.org, and is covered under the GNU Free Documentation License (except
 114+Documentation for both end-users and site administrators is available on
 115+MediaWiki.org, and is covered under the GNU Free Documentation License (except
113116 for pages that explicitly state that their contents are in the public domain):
114117
115118 http://www.mediawiki.org/wiki/Documentation
Index: trunk/phase3/includes/PatrolLog.php
@@ -39,6 +39,8 @@
4040 * @return String
4141 */
4242 public static function makeActionText( $title, $params, $skin ) {
 43+ global $wgLang;
 44+
4345 list( $cur, /* $prev */, $auto ) = $params;
4446 if( is_object( $skin ) ) {
4547 # Standard link to the page in question
@@ -52,7 +54,7 @@
5355
5456 $diff = $skin->link(
5557 $title,
56 - htmlspecialchars( wfMsg( 'patrol-log-diff', $cur ) ),
 58+ htmlspecialchars( wfMsg( 'patrol-log-diff', $wgLang->formatNum( $cur, true ) ) ),
5759 array(),
5860 $query,
5961 array( 'known', 'noclasses' )

Status & tagging log