r88277 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88276‎ | r88277 | r88278 >
Date:22:54, 16 May 2011
Author:krinkle
Status:ok
Tags:
Comment:
Update deprecated shortcuts to current values as of 2011-version of QUnit
* equals -> equal
* same -> deepEqual
Modified paths:
  • /trunk/phase3/resources/test/unit/jquery/jquery.colorUtil.js (modified) (history)
  • /trunk/phase3/resources/test/unit/mediawiki.util/mediawiki.util.js (modified) (history)
  • /trunk/phase3/resources/test/unit/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/test/unit/jquery/jquery.colorUtil.js
@@ -7,27 +7,27 @@
88
99 test( 'getRGB', function(){
1010
11 - equals( typeof jQuery.colorUtil.getRGB(), 'undefined', 'No arguments' );
12 - equals( typeof jQuery.colorUtil.getRGB( '' ), 'undefined', 'Empty string' );
13 - same( jQuery.colorUtil.getRGB( [0, 100, 255] ), [0, 100, 255], 'Array' );
14 - same( jQuery.colorUtil.getRGB( 'rgb(0,100,255)' ), [0, 100, 255], 'Parse simple string' );
15 - same( jQuery.colorUtil.getRGB( 'rgb(0, 100, 255)' ), [0, 100, 255], 'Parse simple string (whitespace)' );
16 - same( jQuery.colorUtil.getRGB( 'rgb(0%,20%,40%)' ), [0, 51, 102], 'Parse percentages string' );
17 - same( jQuery.colorUtil.getRGB( 'rgb(0%, 20%, 40%)' ), [0, 51, 102], 'Parse percentages string (whitespace)' );
18 - same( jQuery.colorUtil.getRGB( '#f2ddee' ), [242, 221, 238], 'Hex string: 6 char lowercase' );
19 - same( jQuery.colorUtil.getRGB( '#f2DDEE' ), [242, 221, 238], 'Hex string: 6 char uppercase' );
20 - same( jQuery.colorUtil.getRGB( '#f2DdEe' ), [242, 221, 238], 'Hex string: 6 char mixed' );
21 - same( jQuery.colorUtil.getRGB( '#eee' ), [238, 238, 238], 'Hex string: 3 char lowercase' );
22 - same( jQuery.colorUtil.getRGB( '#EEE' ), [238, 238, 238], 'Hex string: 3 char uppercase' );
23 - same( jQuery.colorUtil.getRGB( '#eEe' ), [238, 238, 238], 'Hex string: 3 char mixed' );
24 - same( jQuery.colorUtil.getRGB( 'rgba(0, 0, 0, 0)' ), [255, 255, 255], 'Zero rgba for Safari 3; Transparent (whitespace)' );
 11+ equal( typeof jQuery.colorUtil.getRGB(), 'undefined', 'No arguments' );
 12+ equal( typeof jQuery.colorUtil.getRGB( '' ), 'undefined', 'Empty string' );
 13+ deepEqual( jQuery.colorUtil.getRGB( [0, 100, 255] ), [0, 100, 255], 'Array' );
 14+ deepEqual( jQuery.colorUtil.getRGB( 'rgb(0,100,255)' ), [0, 100, 255], 'Parse simple string' );
 15+ deepEqual( jQuery.colorUtil.getRGB( 'rgb(0, 100, 255)' ), [0, 100, 255], 'Parse simple string (whitespace)' );
 16+ deepEqual( jQuery.colorUtil.getRGB( 'rgb(0%,20%,40%)' ), [0, 51, 102], 'Parse percentages string' );
 17+ deepEqual( jQuery.colorUtil.getRGB( 'rgb(0%, 20%, 40%)' ), [0, 51, 102], 'Parse percentages string (whitespace)' );
 18+ deepEqual( jQuery.colorUtil.getRGB( '#f2ddee' ), [242, 221, 238], 'Hex string: 6 char lowercase' );
 19+ deepEqual( jQuery.colorUtil.getRGB( '#f2DDEE' ), [242, 221, 238], 'Hex string: 6 char uppercase' );
 20+ deepEqual( jQuery.colorUtil.getRGB( '#f2DdEe' ), [242, 221, 238], 'Hex string: 6 char mixed' );
 21+ deepEqual( jQuery.colorUtil.getRGB( '#eee' ), [238, 238, 238], 'Hex string: 3 char lowercase' );
 22+ deepEqual( jQuery.colorUtil.getRGB( '#EEE' ), [238, 238, 238], 'Hex string: 3 char uppercase' );
 23+ deepEqual( jQuery.colorUtil.getRGB( '#eEe' ), [238, 238, 238], 'Hex string: 3 char mixed' );
 24+ deepEqual( jQuery.colorUtil.getRGB( 'rgba(0, 0, 0, 0)' ), [255, 255, 255], 'Zero rgba for Safari 3; Transparent (whitespace)' );
2525 // Perhaps this is a bug in colorUtil, but it is the current behaviour so, let's keep track
2626 // would that ever chnge
27 - equals( typeof jQuery.colorUtil.getRGB( 'rgba(0,0,0,0)' ), 'undefined', 'Zero rgba without whitespace' );
 27+ equal( typeof jQuery.colorUtil.getRGB( 'rgba(0,0,0,0)' ), 'undefined', 'Zero rgba without whitespace' );
2828
29 - same( jQuery.colorUtil.getRGB( 'lightGreen' ), [144, 238, 144], 'Color names (lightGreen)' );
30 - same( jQuery.colorUtil.getRGB( 'lightGreen' ), [144, 238, 144], 'Color names (transparent)' );
31 - equals( typeof jQuery.colorUtil.getRGB( 'mediaWiki' ), 'undefined', 'Inexisting Color name' );
 29+ deepEqual( jQuery.colorUtil.getRGB( 'lightGreen' ), [144, 238, 144], 'Color names (lightGreen)' );
 30+ deepEqual( jQuery.colorUtil.getRGB( 'lightGreen' ), [144, 238, 144], 'Color names (transparent)' );
 31+ equal( typeof jQuery.colorUtil.getRGB( 'mediaWiki' ), 'undefined', 'Inexisting Color name' );
3232
3333 });
3434
@@ -38,9 +38,9 @@
3939 };
4040
4141 ok( hsl, 'Basic return evaluation' );
42 - same( dualDecimals(hsl[0]) , 0.33, 'rgb(144, 238, 144): H 0.33' );
43 - same( dualDecimals(hsl[1]) , 0.73, 'rgb(144, 238, 144): S 0.73' );
44 - same( dualDecimals(hsl[2]) , 0.75, 'rgb(144, 238, 144): L 0.75' );
 42+ deepEqual( dualDecimals(hsl[0]) , 0.33, 'rgb(144, 238, 144): H 0.33' );
 43+ deepEqual( dualDecimals(hsl[1]) , 0.73, 'rgb(144, 238, 144): S 0.73' );
 44+ deepEqual( dualDecimals(hsl[2]) , 0.75, 'rgb(144, 238, 144): L 0.75' );
4545
4646 });
4747
@@ -48,9 +48,9 @@
4949 var rgb = jQuery.colorUtil.hslToRgb( 0.3, 0.7, 0.8 );
5050
5151 ok( rgb, 'Basic return evaluation' );
52 - same( Math.round(rgb[0]) , 183, 'hsl(0.3, 0.7, 0.8): R 183' );
53 - same( Math.round(rgb[1]) , 240, 'hsl(0.3, 0.7, 0.8): G 240' );
54 - same( Math.round(rgb[2]) , 168, 'hsl(0.3, 0.7, 0.8): B 168' );
 52+ deepEqual( Math.round(rgb[0]) , 183, 'hsl(0.3, 0.7, 0.8): R 183' );
 53+ deepEqual( Math.round(rgb[1]) , 240, 'hsl(0.3, 0.7, 0.8): G 240' );
 54+ deepEqual( Math.round(rgb[2]) , 168, 'hsl(0.3, 0.7, 0.8): B 168' );
5555
5656 });
5757
@@ -58,10 +58,10 @@
5959
6060 var a = jQuery.colorUtil.getColorBrightness( 'red', +0.1 );
6161
62 - equals( a, 'rgb(255,50,50)', 'Start with named color, brighten 10%' );
 62+ equal( a, 'rgb(255,50,50)', 'Start with named color, brighten 10%' );
6363
6464 var b = jQuery.colorUtil.getColorBrightness( 'rgb(200,50,50)', -0.2 );
6565
66 - equals( b, 'rgb(118,29,29)', 'Start with rgb string, darken 10%' );
 66+ equal( b, 'rgb(118,29,29)', 'Start with rgb string, darken 10%' );
6767
6868 });
Index: trunk/phase3/resources/test/unit/mediawiki.util/mediawiki.util.js
@@ -8,13 +8,13 @@
99
1010 test( 'rawurlencode', function(){
1111
12 - equals( mw.util.rawurlencode( 'Test:A & B/Here' ), 'Test%3AA%20%26%20B%2FHere' );
 12+ equal( mw.util.rawurlencode( 'Test:A & B/Here' ), 'Test%3AA%20%26%20B%2FHere' );
1313
1414 });
1515
1616 test( 'wikiUrlencode', function(){
1717
18 - equals( mw.util.wikiUrlencode( 'Test:A & B/Here' ), 'Test:A_%26_B/Here' );
 18+ equal( mw.util.wikiUrlencode( 'Test:A & B/Here' ), 'Test:A_%26_B/Here' );
1919
2020 });
2121
@@ -22,10 +22,10 @@
2323
2424 var a = mw.util.addCSS( '#bodyContent { visibility: hidden; }' );
2525 ok( a, 'function works' );
26 - same( a.disabled, false, 'property "disabled" is available and set to false' );
 26+ deepEqual( a.disabled, false, 'property "disabled" is available and set to false' );
2727
2828 var $b = $('#bodyContent');
29 - equals( $b.css('visibility'), 'hidden', 'Added style properties are in effect.' );
 29+ equal( $b.css('visibility'), 'hidden', 'Added style properties are in effect.' );
3030
3131
3232 });
@@ -43,11 +43,11 @@
4444
4545 var hrefA = mw.util.wikiGetlink( 'Sandbox' );
4646
47 - equals( hrefA, '/wiki/Sandbox', 'Simple title; Get link for "Sandbox"' );
 47+ equal( hrefA, '/wiki/Sandbox', 'Simple title; Get link for "Sandbox"' );
4848
4949 var hrefB = mw.util.wikiGetlink( 'Foo:Sandbox ? 5+5=10 ! (test)/subpage' );
5050
51 - equals( hrefB, '/wiki/Foo:Sandbox_%3F_5%2B5%3D10_%21_%28test%29/subpage', 'Advanced title; Get link for "Foo:Sandbox ? 5+5=10 ! (test)/subpage"' );
 51+ equal( hrefB, '/wiki/Foo:Sandbox_%3F_5%2B5%3D10_%21_%28test%29/subpage', 'Advanced title; Get link for "Foo:Sandbox ? 5+5=10 ! (test)/subpage"' );
5252
5353 });
5454
@@ -131,7 +131,7 @@
132132
133133 test( 'tooltipAccessKey', function(){
134134
135 - equals( typeof mw.util.tooltipAccessKeyPrefix, 'string', 'mw.util.tooltipAccessKeyPrefix must be a string' );
 135+ equal( typeof mw.util.tooltipAccessKeyPrefix, 'string', 'mw.util.tooltipAccessKeyPrefix must be a string' );
136136 ok( mw.util.tooltipAccessKeyRegexp instanceof RegExp, 'mw.util.tooltipAccessKeyRegexp instance of RegExp' );
137137 ok( mw.util.updateTooltipAccessKeys, 'mw.util.updateTooltipAccessKeys' );
138138
@@ -140,7 +140,7 @@
141141 test( '$content', function(){
142142
143143 ok( mw.util.$content instanceof jQuery, 'mw.util.$content instance of jQuery' );
144 - same( mw.util.$content.length, 1, 'mw.util.$content must have length of 1' );
 144+ deepEqual( mw.util.$content.length, 1, 'mw.util.$content must have length of 1' );
145145
146146 });
147147
@@ -152,8 +152,8 @@
153153
154154 var b = mw.util.addPortletLink( "p-tb", "http://mediawiki.org/", "MediaWiki.org", "t-mworg", "Go to MediaWiki.org ", "m", "#t-rl" );
155155
156 - equals( $(a).text(), 'ResourceLoader', 'Link contains correct text' );
157 - equals( $(b).next().text(), 'ResourceLoader', 'Link was inserted in correct nextnode position' );
 156+ equal( $(a).text(), 'ResourceLoader', 'Link contains correct text' );
 157+ equal( $(b).next().text(), 'ResourceLoader', 'Link was inserted in correct nextnode position' );
158158
159159 });
160160
@@ -167,36 +167,36 @@
168168
169169 test( 'validateEmail', function(){
170170
171 - same( mw.util.validateEmail( "" ), null, 'Empty string should return null' );
172 - same( mw.util.validateEmail( "user@localhost" ), true );
 171+ deepEqual( mw.util.validateEmail( "" ), null, 'Empty string should return null' );
 172+ deepEqual( mw.util.validateEmail( "user@localhost" ), true );
173173
174174 // testEmailWithCommasAreInvalids
175 - same( mw.util.validateEmail( "user,foo@example.org" ), false, 'Comma' );
176 - same( mw.util.validateEmail( "userfoo@ex,ample.org" ), false, 'Comma' );
 175+ deepEqual( mw.util.validateEmail( "user,foo@example.org" ), false, 'Comma' );
 176+ deepEqual( mw.util.validateEmail( "userfoo@ex,ample.org" ), false, 'Comma' );
177177
178178 // testEmailWithHyphens
179 - same( mw.util.validateEmail( "user-foo@example.org" ), true, 'Hyphen' );
180 - same( mw.util.validateEmail( "userfoo@ex-ample.org" ), true, 'Hyphen' );
 179+ deepEqual( mw.util.validateEmail( "user-foo@example.org" ), true, 'Hyphen' );
 180+ deepEqual( mw.util.validateEmail( "userfoo@ex-ample.org" ), true, 'Hyphen' );
181181
182182 });
183183
184184 test( 'isIPv6Address', function(){
185185
186186 // Based on IPTest.php > IPv6
187 - same( mw.util.isIPv6Address( "" ), false, 'Empty string is not an IP' );
188 - same( mw.util.isIPv6Address( ":fc:100::" ), false, 'IPv6 starting with lone ":"' );
189 - same( mw.util.isIPv6Address( "fc:100::" ), true );
190 - same( mw.util.isIPv6Address( "fc:100:a:d:1:e:ac::" ), true );
191 - same( mw.util.isIPv6Address( ":::" ), false );
192 - same( mw.util.isIPv6Address( "::0:" ), false );
 187+ deepEqual( mw.util.isIPv6Address( "" ), false, 'Empty string is not an IP' );
 188+ deepEqual( mw.util.isIPv6Address( ":fc:100::" ), false, 'IPv6 starting with lone ":"' );
 189+ deepEqual( mw.util.isIPv6Address( "fc:100::" ), true );
 190+ deepEqual( mw.util.isIPv6Address( "fc:100:a:d:1:e:ac::" ), true );
 191+ deepEqual( mw.util.isIPv6Address( ":::" ), false );
 192+ deepEqual( mw.util.isIPv6Address( "::0:" ), false );
193193
194194 });
195195
196196 test( 'isIPv4Address', function(){
197197
198198 // Based on IPTest.php > IPv4
199 - same( mw.util.isIPv4Address( "" ), false, 'Empty string is not an IP' );
200 - same( mw.util.isIPv4Address( "...." ), false );
201 - same( mw.util.isIPv4Address( "1.24.52.13" ), true );
 199+ deepEqual( mw.util.isIPv4Address( "" ), false, 'Empty string is not an IP' );
 200+ deepEqual( mw.util.isIPv4Address( "...." ), false );
 201+ deepEqual( mw.util.isIPv4Address( "1.24.52.13" ), true );
202202
203203 });
Index: trunk/phase3/resources/test/unit/mediawiki/mediawiki.js
@@ -4,51 +4,51 @@
55
66 ok( window.jQuery, 'jQuery defined' );
77 ok( window.$j, '$j defined' );
8 - equals( window.$j, window.jQuery, '$j alias to jQuery' );
 8+ equal( window.$j, window.jQuery, '$j alias to jQuery' );
99
1010 ok( window.mediaWiki, 'mediaWiki defined' );
1111 ok( window.mw, 'mw defined' );
12 - equals( window.mw, window.mediaWiki, 'mw alias to mediaWiki' );
 12+ equal( window.mw, window.mediaWiki, 'mw alias to mediaWiki' );
1313
1414 });
1515
1616 test( 'jQuery.extend', function(){
1717
18 - equals( $j.trimLeft( ' foo bar ' ), 'foo bar ', 'trimLeft' );
19 - equals( $j.trimRight( ' foo bar ' ), ' foo bar', 'trimRight' );
20 - equals( $j.ucFirst( 'foo'), 'Foo', 'ucFirst' );
 18+ equal( $j.trimLeft( ' foo bar ' ), 'foo bar ', 'trimLeft' );
 19+ equal( $j.trimRight( ' foo bar ' ), ' foo bar', 'trimRight' );
 20+ equal( $j.ucFirst( 'foo'), 'Foo', 'ucFirst' );
2121
22 - equals( $j.escapeRE( '<!-- ([{+mW+}]) $^|?>' ),
 22+ equal( $j.escapeRE( '<!-- ([{+mW+}]) $^|?>' ),
2323 '<!\\-\\- \\(\\[\\{\\+mW\\+\\}\\]\\) \\$\\^\\|\\?>', 'escapeRE - Escape specials' );
24 - equals( $j.escapeRE( 'ABCDEFGHIJKLMNOPQRSTUVWXYZ' ),
 24+ equal( $j.escapeRE( 'ABCDEFGHIJKLMNOPQRSTUVWXYZ' ),
2525 'ABCDEFGHIJKLMNOPQRSTUVWXYZ', 'escapeRE - Leave uppercase alone' );
26 - equals( $j.escapeRE( 'abcdefghijklmnopqrstuvwxyz' ),
 26+ equal( $j.escapeRE( 'abcdefghijklmnopqrstuvwxyz' ),
2727 'abcdefghijklmnopqrstuvwxyz', 'escapeRE - Leave lowercase alone' );
28 - equals( $j.escapeRE( '0123456789' ), '0123456789', 'escapeRE - Leave numbers alone' );
 28+ equal( $j.escapeRE( '0123456789' ), '0123456789', 'escapeRE - Leave numbers alone' );
2929
30 - same( $j.isDomElement( document.getElementById( 'qunit-header' ) ), true,
 30+ deepEqual( $j.isDomElement( document.getElementById( 'qunit-header' ) ), true,
3131 'isDomElement: #qunit-header Node' );
32 - same( $j.isDomElement( document.getElementById( 'random-name' ) ), false,
 32+ deepEqual( $j.isDomElement( document.getElementById( 'random-name' ) ), false,
3333 'isDomElement: #random-name (null)' );
34 - same( $j.isDomElement( document.getElementsByTagName( 'div' ) ), false,
 34+ deepEqual( $j.isDomElement( document.getElementsByTagName( 'div' ) ), false,
3535 'isDomElement: getElementsByTagName Array' );
36 - same( $j.isDomElement( document.getElementsByTagName( 'div' )[0] ), true,
 36+ deepEqual( $j.isDomElement( document.getElementsByTagName( 'div' )[0] ), true,
3737 'isDomElement: getElementsByTagName(..)[0] Node' );
38 - same( $j.isDomElement( $j( 'div' ) ), false,
 38+ deepEqual( $j.isDomElement( $j( 'div' ) ), false,
3939 'isDomElement: jQuery object' );
40 - same( $j.isDomElement( $j( 'div' ).get(0) ), true,
 40+ deepEqual( $j.isDomElement( $j( 'div' ).get(0) ), true,
4141 'isDomElement: jQuery object > Get node' );
42 - same( $j.isDomElement( document.createElement( 'div' ) ), true,
 42+ deepEqual( $j.isDomElement( document.createElement( 'div' ) ), true,
4343 'isDomElement: createElement' );
44 - same( $j.isDomElement( { foo: 1 } ), false,
 44+ deepEqual( $j.isDomElement( { foo: 1 } ), false,
4545 'isDomElement: Object' );
4646
47 - equals( $j.isEmpty( 'string' ), false, 'isEmptry: "string"' );
48 - equals( $j.isEmpty( '0' ), true, 'isEmptry: "0"' );
49 - equals( $j.isEmpty( [] ), true, 'isEmptry: []' );
50 - equals( $j.isEmpty( {} ), true, 'isEmptry: {}' );
 47+ equal( $j.isEmpty( 'string' ), false, 'isEmptry: "string"' );
 48+ equal( $j.isEmpty( '0' ), true, 'isEmptry: "0"' );
 49+ equal( $j.isEmpty( [] ), true, 'isEmptry: []' );
 50+ equal( $j.isEmpty( {} ), true, 'isEmptry: {}' );
5151 // Documented behaviour
52 - equals( $j.isEmpty( { length: 0 } ), true, 'isEmptry: { length: 0 }' );
 52+ equal( $j.isEmpty( { length: 0 } ), true, 'isEmptry: { length: 0 }' );
5353
5454 ok( $j.compareArray( [0, 'a', [], [2, 'b'] ], [0, "a", [], [2, "b"] ] ),
5555 'compareArray: Two the same deep arrays' );
@@ -72,8 +72,8 @@
7373 ok( mw.config.set( 'lipsum', 'Lorem ipsum' ), 'set: lipsum' );
7474 ok( mw.config.exists( 'lipsum' ), 'exists: lipsum (existant)' );
7575
76 - equals( mw.config.get( 'lipsum' ), 'Lorem ipsum', 'get: lipsum' );
77 - equals( mw.config.get( ['lipsum'] ).lipsum, 'Lorem ipsum', 'get: lipsum (multiple)' );
 76+ equal( mw.config.get( 'lipsum' ), 'Lorem ipsum', 'get: lipsum' );
 77+ equal( mw.config.get( ['lipsum'] ).lipsum, 'Lorem ipsum', 'get: lipsum (multiple)' );
7878
7979 });
8080
@@ -87,9 +87,9 @@
8888 var hello = mw.message( 'hello' );
8989 ok( hello, 'hello: Instance of Message' );
9090
91 - equals( hello.format, 'parse', 'Message property "format" (default value)' );
92 - equals( hello.key, 'hello', 'Message property "key" (currect key)' );
93 - same( hello.parameters, [], 'Message property "parameters" (default value)' );
 91+ equal( hello.format, 'parse', 'Message property "format" (default value)' );
 92+ equal( hello.key, 'hello', 'Message property "key" (currect key)' );
 93+ deepEqual( hello.parameters, [], 'Message property "parameters" (default value)' );
9494
9595
9696 ok( hello.params, 'Message prototype "params"');
@@ -99,12 +99,12 @@
100100 ok( hello.escaped, 'Message prototype "escaped"');
101101 ok( hello.exists, 'Message prototype "exists"');
102102
103 - equals( hello.toString(), 'Hello <b>awesome</b> world', 'Message.toString() test');
104 - equals( hello.escaped(), 'Hello &lt;b&gt;awesome&lt;/b&gt; world', 'Message.escaped() test');
105 - same( hello.exists(), true, 'Message.exists() test');
 103+ equal( hello.toString(), 'Hello <b>awesome</b> world', 'Message.toString() test');
 104+ equal( hello.escaped(), 'Hello &lt;b&gt;awesome&lt;/b&gt; world', 'Message.escaped() test');
 105+ deepEqual( hello.exists(), true, 'Message.exists() test');
106106
107 - equals( mw.msg( 'random' ), '<random>', 'square brackets around inexistant messages' );
108 - equals( mw.msg( 'hello' ), 'Hello <b>awesome</b> world', 'get message with default options' );
 107+ equal( mw.msg( 'random' ), '<random>', 'square brackets around inexistant messages' );
 108+ equal( mw.msg( 'hello' ), 'Hello <b>awesome</b> world', 'get message with default options' );
109109
110110 // params, toString, parse, plain, escaped, exists
111111 });
@@ -119,32 +119,32 @@
120120 mw.loader.implement( 'is.awesome', [location.href.match(/[^#\?]*/)[0] + 'sample/awesome.js'], {}, {} );
121121 mw.loader.using( 'is.awesome', function(){
122122 start();
123 - same( window.awesome, true, 'Implementing a module, is the callback timed properly ?');
 123+ deepEqual( window.awesome, true, 'Implementing a module, is the callback timed properly ?');
124124 }, function(){
125125 start();
126 - same( 'mw.loader.using error callback fired', true, 'Implementing a module, is the callback timed properly ?');
 126+ deepEqual( 'mw.loader.using error callback fired', true, 'Implementing a module, is the callback timed properly ?');
127127 });
128128
129129 });
130130
131131 test( 'mw.html', function(){
132132
133 - equals( mw.html.escape( '<mw awesome="awesome" value=\'test\' />' ),
 133+ equal( mw.html.escape( '<mw awesome="awesome" value=\'test\' />' ),
134134 '&lt;mw awesome=&quot;awesome&quot; value=&#039;test&#039; /&gt;', 'html.escape()' );
135135
136 - equals( mw.html.element( 'div' ), '<div/>', 'mw.html.element() DIV (simple)' );
 136+ equal( mw.html.element( 'div' ), '<div/>', 'mw.html.element() DIV (simple)' );
137137
138 - equals( mw.html.element( 'div',
 138+ equal( mw.html.element( 'div',
139139 { id: 'foobar' } ),
140140 '<div id="foobar"/>',
141141 'mw.html.element() DIV (attribs)' );
142142
143 - equals( mw.html.element( 'div',
 143+ equal( mw.html.element( 'div',
144144 null, 'a' ),
145145 '<div>a</div>',
146146 'mw.html.element() DIV (content)' );
147147
148 - equals( mw.html.element( 'a',
 148+ equal( mw.html.element( 'a',
149149 { href: 'http://mediawiki.org/w/index.php?title=RL&action=history' }, 'a' ),
150150 '<a href="http://mediawiki.org/w/index.php?title=RL&amp;action=history">a</a>',
151151 'mw.html.element() DIV (attribs + content)' );

Status & tagging log