r88252 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88251‎ | r88252 | r88253 >
Date:17:51, 16 May 2011
Author:siebrand
Status:reverted
Tags:
Comment:
Remove verboseness (image and infobox) in Special:Contributions for diff size display as added in r88111.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -2016,7 +2016,6 @@
20172017 'sp-contributions-footer',
20182018 'sp-contributions-footer-anon',
20192019 'sp-contributions-showsizediff',
2020 - 'sp-contributions-showsizediff-warn',
20212020 ),
20222021 'whatlinkshere' => array(
20232022 'whatlinkshere',
Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -380,11 +380,7 @@
381381 Xml::label( wfMsg( 'namespace' ), 'namespace' ) . ' ' .
382382 Xml::namespaceSelector( $this->opts['namespace'], '' )
383383 );
384 - $fShowDiff = Xml::infoBox(
385 - Xml::checkLabel( wfMsg( 'sp-contributions-showsizediff' ), 'showSizeDiff', 'mw-show-size-diff', $this->opts['showSizeDiff'] ) . '<br />'.
386 - wfMsgReplaceArgs ( wfMsg( 'sp-contributions-showsizediff-warn' ), array( $wgContLang->formatTimePeriod( $wgRCMaxAge ) ) )
387 - , 'warning-32.png', wfMsg( 'sp-contributions-showsizediff' )
388 - );
 384+ $fShowDiff = Xml::checkLabel( wfMsg( 'sp-contributions-showsizediff' ), 'showSizeDiff', 'mw-show-size-diff', $this->opts['showSizeDiff'] );
389385 }
390386
391387 $f .= Xml::fieldset( wfMsg( 'sp-contributions-search' ) ) .
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2994,7 +2994,6 @@
29952995 'sp-contributions-footer' => '-', # do not translate or duplicate this message to other languages
29962996 'sp-contributions-footer-anon' => '-', # do not translate or duplicate this message to other languages
29972997 'sp-contributions-showsizediff' => 'Display difference in page size',
2998 -'sp-contributions-showsizediff-warn' => 'This instance has recent changes log limited to $1 . If you use this option, pages not in this log will not be displayed',
29992998
30002999 # What links here
30013000 'whatlinkshere' => 'What links here',

Follow-up revisions

RevisionCommit summaryAuthorDate
r95496Revert r8811...reedy17:35, 25 August 2011
r96306Revert r88008 (add size difference to Special:Contributions) and its large gr...catrope21:47, 5 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88111* added an option to toggle the display of diff size with a warning message....freakolowsky17:05, 14 May 2011

Status & tagging log