r88246 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88245‎ | r88246 | r88247 >
Date:15:55, 16 May 2011
Author:j
Status:deferred
Tags:
Comment:
ResumableUpload, its just offset not byteoffset, add installation note to README
Modified paths:
  • /trunk/extensions/ResumableUpload/ApiResumableUpload.php (modified) (history)
  • /trunk/extensions/ResumableUpload/README (modified) (history)

Diff [purge]

Index: trunk/extensions/ResumableUpload/ApiResumableUpload.php
@@ -156,7 +156,7 @@
157157 $required[] = 'filesize';
158158 break;
159159 case ResumableUploadHandler::CHUNK:
160 - $required[] = 'byteoffset';
 160+ $required[] = 'offset';
161161 $required[] = 'chunksession';
162162 // The actual file payload:
163163 $required[] = 'chunk';
@@ -180,7 +180,7 @@
181181 'ignorewarnings' => false,
182182 'chunksession' => null,
183183 'chunk' => null,
184 - 'byteoffset' => null,
 184+ 'offset' => null,
185185 'done' => false,
186186 'watchlist' => array(
187187 ApiBase::PARAM_DFLT => 'preferences',
@@ -204,7 +204,7 @@
205205 'ignorewarnings' => 'Ignore any warnings',
206206 'chunksession' => 'The session key, established on the first contact during the chunked upload',
207207 'chunk' => 'The data in this chunk of a chunked upload',
208 - 'byteoffset' => 'The byte offset range of the uploaded chunk, relative to the complete file',
 208+ 'offset' => 'The start offset of the current chunk in bytes',
209209 'done' => 'Set to 1 on the last chunk of a chunked upload',
210210
211211 'sessionkey' => 'Session key that identifies a previous upload that was stashed temporarily.',
Index: trunk/extensions/ResumableUpload/README
@@ -7,3 +7,9 @@
88
99 This extension needs client JavaScript support.
1010 This can be done with the HTML5 slice api or using the Firefogg extension.
 11+
 12+
 13+To install this extension, add the following line to your LocalSettings.php file:
 14+
 15+require_once( "$IP/extensions/ResumableUpload/ResumableUpload.php" );
 16+

Status & tagging log