r88221 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88220‎ | r88221 | r88222 >
Date:09:52, 16 May 2011
Author:kaldari
Status:ok
Tags:
Comment:
switching buttons to jQuery UI buttons, still need to custom style according to http://www.mediawiki.org/wiki/Style_guide/Forms#Buttons
Modified paths:
  • /trunk/extensions/WikiLove/WikiLove.php (modified) (history)
  • /trunk/extensions/WikiLove/wikiLove.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiLove/WikiLove.php
@@ -105,6 +105,7 @@
106106 ),
107107 'dependencies' => array(
108108 'jquery.ui.dialog',
 109+ 'jquery.ui.button',
109110 'jquery.elastic',
110111 ),
111112 ),
Index: trunk/extensions/WikiLove/wikiLove.js
@@ -126,8 +126,7 @@
127127 .append( '<span class="wlOmitSig">' + mw.msg( 'wikilove-omit-sig' ) + '</span>' )
128128 .append( '<textarea id="wlMessage"></textarea>' )
129129 .append( $('<div id="wlNotify"></div>').html('<input type="checkbox" id="wlNotifyCheckbox" name="notify"/> <label for="wlNotifyCheckbox">Notify user by email</label>') )
130 - .append( '<input id="wlButtonPreview" class="submit" type="submit" value="'
131 - + mw.msg( 'wikilove-button-preview' ) + '"/>' )
 130+ .append( $('<button class="submit" id="wlButtonPreview" type="submit"></button>').button({ label: mw.msg( 'wikilove-button-preview' ) }) )
132131 .append( spinner )
133132 )
134133 .hide();
@@ -138,8 +137,7 @@
139138 .append( '<h3>' + mw.msg( 'wikilove-preview' ) + '</h3>' )
140139 .append( '<div id="wlPreviewArea"></div>' )
141140 .append( $( '<form id="wlSendForm"></form>' )
142 - .append( '<input id="wlButtonSend" class="submit" type="submit" value="'
143 - + mw.msg( 'wikilove-button-send' ) + '"/>' )
 141+ .append( $('<button class="submit" id="wlButtonSend" type="submit"></button>').button({ label: mw.msg( 'wikilove-button-send' ) }) )
144142 .append( spinner )
145143 )
146144 .hide();

Status & tagging log