r88206 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88205‎ | r88206 | r88207 >
Date:23:01, 15 May 2011
Author:ashley
Status:deferred
Tags:
Comment:
SocialProfile: fix what looks like an obvious bug with EditProfile's logging system -- params for LogPage::addEntry() are action (log type), target, description; previous code used the description as the action (wtf) and '' as the description
Modified paths:
  • /trunk/extensions/SocialProfile/UserProfile/SpecialEditProfile.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SocialProfile/UserProfile/SpecialEditProfile.php
@@ -93,10 +93,10 @@
9494 $log->updateRecentChanges = false;
9595 }
9696 $log->addEntry(
 97+ 'profile',
 98+ $target->getUserPage(),
9799 wfMsgForContent( 'user-profile-edit-profile',
98 - array( '[[User:' . $target->getName() . ']]' ) ),
99 - $target->getUserPage(),
100 - ''
 100+ array( '[[User:' . $target->getName() . ']]' ) )
101101 );
102102 $wgOut->addHTML(
103103 '<span class="profile-on">' .

Status & tagging log