r88166 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88165‎ | r88166 | r88167 >
Date:12:36, 15 May 2011
Author:platonides
Status:ok
Tags:
Comment:
Follow up r88053. This was trying to throw the return value of a function called MWException.
Modified paths:
  • /trunk/phase3/includes/resourceloader/ResourceLoader.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/resourceloader/ResourceLoader.php
@@ -574,7 +574,7 @@
575575 if ( is_string( $scripts ) ) {
576576 $scripts = new XmlJsCode( "function( $ ) {{$scripts}}" );
577577 } else if ( !is_array( $scripts ) ) {
578 - throw MWException( 'Invalid scripts error. Array of URLs or string of code expected.' );
 578+ throw new MWException( 'Invalid scripts error. Array of URLs or string of code expected.' );
579579 }
580580 return Xml::encodeJsCall(
581581 'mw.loader.implement',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88053Added direct file loading functionality to debug mode for both scripts and st...tparscal12:15, 14 May 2011

Status & tagging log