r88136 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r88135‎ \| r88136 \| r88137 >
Date:	09:10, 15 May 2011
Author:	tparscal
Status:	ok
Tags:
Comment:	Fixes regression in r88125 - if batch is empty we should bail early
Modified paths:	/trunk/phase3/resources/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.js
—	—	@@ -984,6 +984,10 @@
985	985	}
986	986	}
987	987	}
	988	+ // Early exit if there's nothing to load
	989	+ if ( !batch.length ) {
	990	+ return;
	991	+ }
988	992	// Clean up the queue
989	993	queue = [];
990	994	// Always order modules alphabetically to help reduce cache

Past revisions this follows-up on

Revision	Commit summary	Author	Date
r88125	Removed the go() call, and the suspended until go() is called behavior.	tparscal	23:12, 14 May 2011

Status & tagging log

21:27, 16 May 2011 Krinkle (talk | contribs) changed the status of r88136 [removed: new added: ok]