r88133 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88132‎ | r88133 | r88134 >
Date:06:32, 15 May 2011
Author:aaron
Status:ok
Tags:
Comment:
Marked some _Newtalk functions protected
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -1653,9 +1653,8 @@
16541654 * @param $id String|Int User's IP address for anonymous users, User ID otherwise
16551655 * @param $fromMaster Bool true to fetch from the master, false for a slave
16561656 * @return Bool True if the user has new messages
1657 - * @private
16581657 */
1659 - function checkNewtalk( $field, $id, $fromMaster = false ) {
 1658+ protected function checkNewtalk( $field, $id, $fromMaster = false ) {
16601659 if ( $fromMaster ) {
16611660 $db = wfGetDB( DB_MASTER );
16621661 } else {
@@ -1671,9 +1670,8 @@
16721671 * @param $field String 'user_ip' for anonymous users, 'user_id' otherwise
16731672 * @param $id String|Int User's IP address for anonymous users, User ID otherwise
16741673 * @return Bool True if successful, false otherwise
1675 - * @private
16761674 */
1677 - function updateNewtalk( $field, $id ) {
 1675+ protected function updateNewtalk( $field, $id ) {
16781676 $dbw = wfGetDB( DB_MASTER );
16791677 $dbw->insert( 'user_newtalk',
16801678 array( $field => $id ),
@@ -1693,9 +1691,8 @@
16941692 * @param $field String 'user_ip' for anonymous users, 'user_id' otherwise
16951693 * @param $id String|Int User's IP address for anonymous users, User ID otherwise
16961694 * @return Bool True if successful, false otherwise
1697 - * @private
16981695 */
1699 - function deleteNewtalk( $field, $id ) {
 1696+ protected function deleteNewtalk( $field, $id ) {
17001697 $dbw = wfGetDB( DB_MASTER );
17011698 $dbw->delete( 'user_newtalk',
17021699 array( $field => $id ),

Status & tagging log