r88081 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88080‎ | r88081 | r88082 >
Date:13:56, 14 May 2011
Author:hashar
Status:ok
Tags:
Comment:
bug 28503: add ircs to UrlProtocols in defaultsettings & css
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/skins/modern/main.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/simple/main.css (modified) (history)
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/simple/main.css
@@ -224,6 +224,8 @@
225225 }
226226 #bodyContent a[href ^="irc://"],
227227 #bodyContent a.extiw[href ^="irc://"],
 228+#bodyContent a[href ^="ircs://"],
 229+#bodyContent a.extiw[href ^="ircs://"],
228230 .link-irc {
229231 background: url("discussionitem_icon.gif") center right no-repeat;
230232 padding-right: 18px;
Index: trunk/phase3/skins/vector/screen.css
@@ -1082,6 +1082,8 @@
10831083 }
10841084 div#content a[href ^="irc://"],
10851085 div#content a.extiw[href ^="irc://"],
 1086+div#content a[href ^="ircs://"],
 1087+div#content a.extiw[href ^="ircs://"],
10861088 .link-irc {
10871089 /* @embed */
10881090 background: url(images/talk-icon.png) center right no-repeat;
@@ -1231,4 +1233,4 @@
12321234 /* Tooltips are outside of the normal body code, so this helps make the size of the text sensible */
12331235 .tipsy {
12341236 font-size: 0.8em;
1235 -}
\ No newline at end of file
 1237+}
Index: trunk/phase3/skins/monobook/main.css
@@ -516,6 +516,7 @@
517517 padding-right: 18px;
518518 }
519519 #bodyContent a.external[href ^="irc://"],
 520+#bodyContent a.external[href ^="ircs://"],
520521 .link-irc {
521522 /* @embed */
522523 background: url(discussionitem_icon.gif) center right no-repeat;
@@ -1277,4 +1278,4 @@
12781279 /* Tooltips are outside of the normal body code, so this helps make the size of the text sensible */
12791280 .tipsy {
12801281 font-size: 127%;
1281 -}
\ No newline at end of file
 1282+}
Index: trunk/phase3/skins/modern/main.css
@@ -441,6 +441,8 @@
442442 }
443443 #mw_content a[href ^="irc://"],
444444 #mw_content a.extiw[href ^="irc://"],
 445+#mw_content a[href ^="ircs://"],
 446+#mw_content a.extiw[href ^="ircs://"],
445447 .link-irc {
446448 /* @embed */
447449 background: url(discussionitem_icon.gif) center right no-repeat;
@@ -913,4 +915,4 @@
914916 /* @noflip */
915917 html > body.rtl div#mw_contentholder ul#filetoc {
916918 display: block;
917 -}
\ No newline at end of file
 919+}
Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -20,6 +20,7 @@
2121 === New features in 1.19 ===
2222 * (bug 28916) A way to to toggle mw.config legacy globals settings from
2323 LocalSettings.php has been created by introducing $wgLegacyJavaScriptGlobals.
 24+* (bug 28503) Support for ircs:// URL protocols
2425
2526 === Bug fixes in 1.19 ===
2627 * (bug 10154) Don't allow user to specify days beyond $wgRCMaxAge.
Index: trunk/phase3/includes/DefaultSettings.php
@@ -2810,6 +2810,7 @@
28112811 'https://',
28122812 'ftp://',
28132813 'irc://',
 2814+ 'ircs://', // @bug 28503
28142815 'gopher://',
28152816 'telnet://', // Well if we're going to support the above.. -ævar
28162817 'nntp://', // @bug 3808 RFC 1738

Status & tagging log