r88050 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r88049‎ | r88050 | r88051 >
Date:12:01, 14 May 2011
Author:hashar
Status:ok
Tags:
Comment:
Fix MWNamespaceTest::testGetTalkExceptions()

It was actually testing for associated. Thanks copy & paste for this bug.

Test result:

$ php phpunit.php -c suite.xml includes/MWNamespaceTest.php
.........IIIII..........
Tests: 24, Assertions: 99, Incomplete: 5.
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/MWNamespaceTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/MWNamespaceTest.php
——@@ -96,8 +96,8 @@
9797 * @expectedException MWException
9898 */
9999 public function testGetTalkExceptions() {
100 - $this->assertNull( MWNamespace::getAssociated( NS_MEDIA ) );
101 - $this->assertNull( MWNamespace::getAssociated( NS_SPECIAL ) );
 100+ $this->assertNull( MWNamespace::getTalk( NS_MEDIA ) );
 101+ $this->assertNull( MWNamespace::getTalk( NS_SPECIAL ) );
102102 }
103103
104104 /**

Status & tagging log