r88034 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88033‎ | r88034 | r88035 >
Date:09:24, 14 May 2011
Author:catrope
Status:ok
Tags:
Comment:
Followup r87711: add ! to the forbidden characters list for module names, per CR
Modified paths:
  • /trunk/phase3/includes/resourceloader/ResourceLoader.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/resourceloader/ResourceLoader.php
@@ -226,8 +226,8 @@
227227 }
228228
229229 // Check $name for illegal characters
230 - if ( preg_match( '/[|,]/', $name ) ) {
231 - throw new MWException( "ResourceLoader module name '$name' is invalid. Names may not contain pipes (|) or commas (,)" );
 230+ if ( preg_match( '/[|,!]/', $name ) ) {
 231+ throw new MWException( "ResourceLoader module name '$name' is invalid. Names may not contain pipes (|), commas (,) or exclamation marks (!)" );
232232 }
233233
234234 // Attach module

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87711(bug 28840) Commit patch by bawolff that encodes dots in ResourceLoader modul...catrope13:10, 9 May 2011

Status & tagging log