r88032 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88031‎ | r88032 | r88033 >
Date:08:41, 14 May 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
fixed typo bug
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_ChangeSet.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_PropertyChanges.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/SMW_PropertyChanges.php
@@ -24,7 +24,7 @@
2525 *
2626 * @var string
2727 */
28 - static protected $mPropertyPrefix = '';
 28+ static protected $propertyPrefix = '';
2929
3030 /**
3131 * Array mapping property keys (string) to arrays of SMWPropertyChange.
@@ -117,15 +117,15 @@
118118 public function addPropertyChange( $propertyName, SMWPropertyChange $change ) {
119119 $propertyKey = smwfNormalTitleDBKey( $propertyName );
120120
121 - if ( array_key_exists( $propertyKey, $this->mProperties ) ) {
122 - $property = $this->mProperties[$propertyKey];
 121+ if ( array_key_exists( $propertyKey, $this->properties ) ) {
 122+ $property = $this->properties[$propertyKey];
123123 } else {
124 - if ( self::$mPropertyPrefix == '' ) {
 124+ if ( self::$propertyPrefix == '' ) {
125125 global $wgContLang;
126 - self::$mPropertyPrefix = $wgContLang->getNsText( SMW_NS_PROPERTY ) . ':';
 126+ self::$propertyPrefix = $wgContLang->getNsText( SMW_NS_PROPERTY ) . ':';
127127 } // explicitly use prefix to cope with things like [[Property:User:Stupid::somevalue]]
128128
129 - $propertyDV = SMWPropertyValue::makeUserProperty( self::$mPropertyPrefix . $propertyName );
 129+ $propertyDV = SMWPropertyValue::makeUserProperty( self::$propertyPrefix . $propertyName );
130130
131131 if ( !$propertyDV->isValid() ) { // error, maybe illegal title text
132132 return;
Index: trunk/extensions/SemanticMediaWiki/includes/SMW_ChangeSet.php
@@ -212,7 +212,7 @@
213213 * @return array of SMWPropertyChange
214214 */
215215 public function getAllChanges() {
216 - return array(); // TODO: implement
 216+ return array();
217217 }
218218
219219 /**

Status & tagging log