r87988 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87987‎ | r87988 | r87989 >
Date:15:28, 13 May 2011
Author:krinkle
Status:ok
Tags:
Comment:
Looks like even margin-top isn't save due to box model differences (ie. becomes 6px in WebKit browser...?). Using visibility insteawd. (Follow-up to r87938, r87970)
Modified paths:
  • /trunk/phase3/resources/test/unit/mediawiki.util/mediawiki.util.js (modified) (history)
  • /trunk/phase3/resources/test/unit/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/test/unit/mediawiki.util/mediawiki.util.js
@@ -20,12 +20,12 @@
2121
2222 test( 'addCSS', function(){
2323
24 - var a = mw.util.addCSS( '#bodyContent { margin-top: 5px; }' );
 24+ var a = mw.util.addCSS( '#bodyContent { visibility: hidden; }' );
2525 ok( a, 'function works' );
2626 same( a.disabled, false, 'property "disabled" is available and set to false' );
2727
2828 var $b = $('#bodyContent');
29 - equals( $b.css('margin-top'), '5px', 'Added style properties are in effect.' );
 29+ equals( $b.css('visibility'), 'hidden', 'Added style properties are in effect.' );
3030
3131
3232 });
Index: trunk/phase3/resources/test/unit/mediawiki/mediawiki.js
@@ -129,9 +129,6 @@
130130
131131 test( 'mw.loader', function(){
132132
133 - // @TODO: More elaborate testing ?
134 - // Difficult due to modules already being loaded
135 - // through it at this point
136133 ok( mw.loader, 'loader defined' );
137134 ok( mw.loader.work, 'loader.work defined' );
138135 ok( mw.loader.register, 'loader.register defined' );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87938Remove unneeded parens in $.compareObject; Fix addCSS QUnit test for IE6 whic...krinkle23:03, 12 May 2011
r87970comparing colors cross-browser is Aweful. Turns out Opera normalizes to hexid...krinkle12:43, 13 May 2011

Status & tagging log