r87969 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87968‎ | r87969 | r87970 >
Date:12:30, 13 May 2011
Author:husky
Status:ok
Tags:
Comment:
fixed a bug where the search dialog wouldn't open
Modified paths:
  • /trunk/tools/wp-photocommons/js/admin.js (modified) (history)

Diff [purge]

Index: trunk/tools/wp-photocommons/js/admin.js
@@ -13,9 +13,7 @@
1414 '</a>'
1515 ));
1616
17 - var searchDialog = {};
18 - $('<div id="photocommons-dialog"></div>').appendTo('body').load(PATH + '/search.php?standalone=1', function(){
19 -
 17+ $('<div id="photocommons-dialog"></div>').appendTo('body').load(PATH + '/search.php?standalone=1', function() {
2018 PhotoCommons.init();
2119
2220 dialog = $('#photocommons-dialog').dialog({
@@ -24,13 +22,12 @@
2523 height : 500,
2624 autoOpen: false
2725 });
28 -
2926 });
3027
3128 $('#photocommons-add').live('click', function(e) {
3229 e.preventDefault();
3330
34 - searchDialog.dialog('open');
 31+ $("#photocommons-dialog").dialog('open');
3532
3633 $('#wp-photocommons-images .image').live('click', function() {
3734 var file = $(this).attr('data-filename'),
@@ -48,7 +45,7 @@
4946 tinyMCE.execCommand('mceInsertContent', false, shortcode);
5047 }
5148
52 - searchDialog.dialog('close');
 49+ $("#photocommons-dialog").dialog('close');
5350 });
5451 });
5552 }

Sign-offs

UserFlagDate
Krinkleinspected07:32, 15 May 2011

Status & tagging log