r87950 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87949‎ | r87950 | r87951 >
Date:08:10, 13 May 2011
Author:mkroetzsch
Status:deferred
Tags:
Comment:
removed obsolete method
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_Concept.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_Container.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_Property.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_Record.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_Time.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_URI.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_Record.php
@@ -27,7 +27,7 @@
2828 protected function parseUserValueOrQuery( $value, $querymode ) {
2929 if ( $value == '' ) {
3030 $this->addError( wfMsg( 'smw_novalues' ) );
31 - return $querymode ? new SMWThingDescription():$this->m_data;
 31+ return $querymode ? new SMWThingDescription() : $this->m_data;
3232 }
3333
3434 $subdescriptions = array(); // only used for query mode
@@ -68,7 +68,7 @@
6969 $this->addError( wfMsg( 'smw_novalues' ) );
7070 }
7171 if ( $querymode ) {
72 - return $empty ? new SMWThingDescription():new SMWRecordDescription( $subdescriptions );
 72+ return $empty ? new SMWThingDescription() : new SMWRecordDescription( $subdescriptions );
7373 }
7474 }
7575
Index: trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_Container.php
@@ -16,10 +16,6 @@
1717
1818 protected $m_data;
1919
20 - public function getBaseType() {
21 - return SMWDataValue::TYPE_CONT;
22 - }
23 -
2420 public function __construct( $typeid ) {
2521 parent::__construct( $typeid );
2622 $this->m_data = new SMWSemanticData( null );
Index: trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_Property.php
@@ -53,10 +53,6 @@
5454 */
5555 private $mPropTypeId;
5656
57 - public function getBaseType() {
58 - return SMWDataValue::TYPE_PROP;
59 - }
60 -
6157 /**
6258 * Static function for creating a new property object from a
6359 * propertyname (string) as a user might enter it.
Index: trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_Concept.php
@@ -15,10 +15,6 @@
1616 */
1717 class SMWConceptValue extends SMWDataValue {
1818
19 - public function getBaseType() {
20 - return SMWDataValue::TYPE_CONCEPT;
21 - }
22 -
2319 protected function parseUserValue( $value ) {
2420 throw new Exception( 'Concepts cannot be initialised from user-provided strings. This should not happen.' );
2521 }
Index: trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_Time.php
@@ -134,10 +134,6 @@
135135 /// The year before which we do not accept anything but year numbers and largely discourage calendar models.
136136 const PREHISTORY = -10000;
137137
138 - public function getBaseType() {
139 - return SMWDataValue::TYPE_TIME;
140 - }
141 -
142138 protected function parseUserValue( $value ) {
143139 $value = trim( $value ); // ignore whitespace
144140 $this->m_wikivalue = $value;
Index: trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_URI.php
@@ -32,10 +32,6 @@
3333 */
3434 private $m_mode;
3535
36 - public function getBaseType() {
37 - return SMWDataValue::TYPE_URI;
38 - }
39 -
4036 public function __construct( $typeid ) {
4137 parent::__construct( $typeid );
4238 switch ( $typeid ) {

Status & tagging log