r87896 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87895‎ | r87896 | r87897 >
Date:23:11, 11 May 2011
Author:reedy
Status:ok
Tags:
Comment:
Return comment stuffs
Modified paths:
  • /trunk/phase3/includes/db/DatabaseSqlite.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseSqlite.php
@@ -89,6 +89,8 @@
9090
9191 /**
9292 * Close an SQLite database
 93+ *
 94+ * @return bool
9395 */
9496 function close() {
9597 $this->mOpened = false;
@@ -111,7 +113,7 @@
112114
113115 /**
114116 * Check if the searchindext table is FTS enabled.
115 - * @returns false if not enabled.
 117+ * @return false if not enabled.
116118 */
117119 function checkForEnabledSearch() {
118120 if ( self::$fulltextEnabled === null ) {
@@ -165,6 +167,8 @@
166168
167169 /**
168170 * @see DatabaseBase::isWriteQuery()
 171+ *
 172+ * @return bool
169173 */
170174 function isWriteQuery( $sql ) {
171175 return parent::isWriteQuery( $sql ) && !preg_match( '/^ATTACH\b/i', $sql );
@@ -489,6 +493,8 @@
490494 /**
491495 * Get information about a given field
492496 * Returns false if the field does not exist.
 497+ *
 498+ * @return SQLiteField|false
493499 */
494500 function fieldInfo( $table, $field ) {
495501 $tableName = $this->tableName( $table );
@@ -568,6 +574,10 @@
569575 return call_user_func_array( $function, $args );
570576 }
571577
 578+ /**
 579+ * @param $s string
 580+ * @return string
 581+ */
572582 protected function replaceVars( $s ) {
573583 $s = parent::replaceVars( $s );
574584 if ( preg_match( '/^\s*(CREATE|ALTER) TABLE/i', $s ) ) {
@@ -612,6 +622,8 @@
613623
614624 /*
615625 * Build a concatenation list to feed into a SQL query
 626+ *
 627+ * @return string
616628 */
617629 function buildConcat( $stringList ) {
618630 return '(' . implode( ') || (', $stringList ) . ')';
@@ -641,6 +653,8 @@
642654 *
643655 * @param $prefix Only show tables with this prefix, e.g. mw_
644656 * @param $fname String: calling function name
 657+ *
 658+ * @return array
645659 */
646660 function listTables( $prefix = null, $fname = 'DatabaseSqlite::listTables' ) {
647661 $result = $this->select(

Status & tagging log