r87839 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87838‎ | r87839 | r87840 >
Date:19:45, 10 May 2011
Author:maxsem
Status:ok
Tags:
Comment:
To prevent creepy errors like bug 28908, raised PHPUnit requirement to 3.5
Modified paths:
  • /trunk/phase3/tests/phpunit/phpunit.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/phpunit.php
@@ -51,13 +51,10 @@
5252 }
5353
5454 require_once( 'PHPUnit/Runner/Version.php' );
55 -if( version_compare( PHPUnit_Runner_Version::id(), '3.5.0', '>=' ) ) {
56 - # PHPUnit 3.5.0 introduced a nice autoloader based on class name
57 - require_once( 'PHPUnit/Autoload.php' );
58 -} else {
59 - # Keep the old pre PHPUnit 3.5.0 behaviour for compatibility
60 - require_once( 'PHPUnit/TextUI/Command.php' );
 55+if( version_compare( PHPUnit_Runner_Version::id(), '3.5.0', '<' ) ) {
 56+ die( 'PHPUnit 3.5 or later required, you have ' . PHPUnit_Runner_Version::id() . ".\n" );
6157 }
 58+require_once( 'PHPUnit/Autoload.php' );
6259
6360 require_once( "$IP/tests/TestsAutoLoader.php" );
6461 MediaWikiPHPUnitCommand::main();

Follow-up revisions

RevisionCommit summaryAuthorDate
r92239MFT PHPUnit testing related revisions:...hashar12:13, 15 July 2011

Status & tagging log