r87833 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87832‎ | r87833 | r87834 >
Date:18:11, 10 May 2011
Author:mkroetzsch
Status:deferred
Tags:
Comment:
do not force linebrak after plain list output
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_List.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_List.php
@@ -70,9 +70,9 @@
7171
7272 // Determine mark-up strings used around list items:
7373 if ( ( $this->mFormat == 'ul' ) || ( $this->mFormat == 'ol' ) ) {
74 - $header = '<' . $this->mFormat . '>';
75 - $footer = '</' . $this->mFormat . '>';
76 - $rowstart = '<li>';
 74+ $header = "<" . $this->mFormat . ">\n";
 75+ $footer = "</" . $this->mFormat . ">\n";
 76+ $rowstart = "\t<li>";
7777 $rowend = "</li>\n";
7878 $plainlist = false;
7979 $finallistsep = '';
@@ -112,7 +112,7 @@
113113 }
114114
115115 if ( $header != '' ) {
116 - $result .= "\t\t\t\t$header\n";
 116+ $result .= $header;
117117 }
118118
119119 if ( $this->mIntroTemplate != '' ) {
@@ -139,15 +139,15 @@
140140
141141 // Print footer
142142 if ( $footer != '' ) {
143 - $result .= "\t\t\t\t$footer\n";
 143+ $result .= $footer;
144144 }
145145
146146 if ( $this->mColumns > 1 ) {
147 - $result .= "\t\t\t\t</div>\n";
 147+ $result .= "</div>\n";
148148 }
149149
150150 if ( $this->mColumns > 1 ) {
151 - $result .= '<br style="clear: both">' . "\n";
 151+ $result .= '<br style="clear: both" />' . "\n";
152152 }
153153
154154 return $result;
@@ -292,7 +292,7 @@
293293 $link->setParameter( $this->mOutroTemplate, 'outrotemplate' );
294294 }
295295
296 - $result .= "\t\t\t\t" . $rowstart . $link->getText( SMW_OUTPUT_WIKI, $this->mLinker ) . $rowend . "\n";
 296+ $result .= $rowstart . ' '. $link->getText( SMW_OUTPUT_WIKI, $this->mLinker ) . $rowend;
297297 }
298298
299299 public function getParameters() {

Status & tagging log