r87820 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87819‎ | r87820 | r87821 >
Date:14:26, 10 May 2011
Author:ashley
Status:deferred
Tags:
Comment:
GoogleDocs4MW: intval() should be sufficient enough here (+bump version number and copyright year)
Modified paths:
  • /trunk/extensions/GoogleDocs4MW/GoogleDocs4MW.php (modified) (history)

Diff [purge]

Index: trunk/extensions/GoogleDocs4MW/GoogleDocs4MW.php
@@ -5,9 +5,9 @@
66 *
77 * @file
88 * @ingroup Extensions
9 - * @version 1.0
 9+ * @version 1.1
1010 * @author Jack Phoenix <jack@shoutwiki.com>
11 - * @copyright © 2008-2010 Jack Phoenix
 11+ * @copyright © 2008-2011 Jack Phoenix
1212 * @license http://www.gnu.org/copyleft/gpl.html GNU General Public License 2.0 or later
1313 */
1414
@@ -18,7 +18,7 @@
1919 // Add extension credits that show up on Special:Version
2020 $wgExtensionCredits['parserhook'][] = array(
2121 'name' => 'GoogleDocs4MW',
22 - 'version' => '1.0',
 22+ 'version' => '1.1',
2323 'author' => 'Jack Phoenix',
2424 'description' => 'Adds <tt>&lt;googlespreadsheet&gt;</tt> tag for Google Docs\' spreadsheets display',
2525 'url' => 'http://www.mediawiki.org/wiki/Extension:GoogleDocs4MW'
@@ -39,8 +39,8 @@
4040 $key = htmlspecialchars( $input );
4141
4242 $output = '<iframe class="googlespreadsheetframe" width="' .
43 - htmlspecialchars( $width ) . '" height="' .
44 - htmlspecialchars( $height ) . '" style="' .
 43+ intval( $width ) . '" height="' .
 44+ intval( $height ) . '" style="' .
4545 htmlspecialchars( $style ) .
4646 '" src="http://spreadsheets.google.com/pub?key=' . $key .
4747 '&output=html&widget=true"></iframe>';

Status & tagging log