r87768 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87767‎ | r87768 | r87769 >
Date:20:45, 9 May 2011
Author:awjrichards
Status:ok
Tags:
Comment:
Fixing query to select highs/lows from db prior to caching results to return them in the correct order for stats population
Modified paths:
  • /trunk/extensions/ArticleFeedback/populateAFStatistics.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/populateAFStatistics.php
@@ -165,9 +165,9 @@
166166 'afshl_avg_overall',
167167 'afshl_avg_ratings'
168168 ),
169 - 'afshl_ts = ' . $cur_ts,
 169+ array( 'afshl_ts' => $cur_ts ),
170170 __METHOD__,
171 - array()
 171+ array( "ORDER BY" => "afshl_avg_overall" )
172172 );
173173 // grab the article feedback special page so we can reuse the data structure building code
174174 // FIXME this logic should not be in the special page class

Status & tagging log