r87736 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87735‎ | r87736 | r87737 >
Date:17:02, 9 May 2011
Author:catrope
Status:ok
Tags:
Comment:
1.17wmf1: Update ArticleFeedback to trunk state again
Modified paths:
  • /branches/wmf/1.17wmf1/extensions/ArticleFeedback/ArticleFeedback.i18n.php (modified) (history)
  • /branches/wmf/1.17wmf1/extensions/ArticleFeedback/SpecialArticleFeedback.php (modified) (history)
  • /branches/wmf/1.17wmf1/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/extensions/ArticleFeedback/SpecialArticleFeedback.php
@@ -29,12 +29,18 @@
3030 // .. and the lowest rated articles
3131 $lows = $this->getDailyLows( $highs_lows );
3232
 33+ // provide some messaging above high/low tables
 34+ $wgOut->addWikiText( wfMsg( 'articleFeedback-copy-above-highlow-tables' ));
 35+
3336 //render daily highs table
3437 $this->renderDailyHighsAndLows( $highs, wfMsg( 'articleFeedback-table-caption-dailyhighs', $wgLang->date( time() )));
3538
3639 //render daily lows table
3740 $this->renderDailyHighsAndLows( $lows, wfMsg( 'articleFeedback-table-caption-dailylows', $wgLang->date( time() )));
3841
 42+ // provide some messaging below high/low tables
 43+ $wgOut->addWikiText( wfMsg( 'articleFeedback-copy-below-highlow-tables' ));
 44+
3945 /*
4046 This functionality does not exist yet.
4147 $this->renderWeeklyMostChanged();
Index: branches/wmf/1.17wmf1/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
@@ -340,7 +340,7 @@
341341 'afanontoken': userrating ? mw.user.id() : '',
342342 'afuserrating': Number( userrating ),
343343 'maxage': 0,
344 - 'smaxage': mw.config.get( 'wgArticleFeedbackSMaxage' )
 344+ 'smaxage': userrating ? 0 : mw.config.get( 'wgArticleFeedbackSMaxage' )
345345 },
346346 'success': function( data ) {
347347 var context = this;
Index: branches/wmf/1.17wmf1/extensions/ArticleFeedback/ArticleFeedback.i18n.php
@@ -84,6 +84,8 @@
8585 'articleFeedback-table-caption-recentlows' => 'Recent lows',
8686 'articleFeedback-table-heading-page' => 'Page',
8787 'articleFeedback-table-heading-average' => 'Average',
 88+ 'articleFeedback-copy-above-highlow-tables' => 'This is an experimental feature. Please provide feedback on the talk page.',
 89+ 'articleFeedback-copy-below-highlow-tables' => 'These tables contain articles that have received at least 10 ratings within the last 24 hours. Averages are calculated by taking the mean of all ratings submitted within the last 24 hours.',
8890 /* EmailCapture */
8991 'articlefeedback-emailcapture-response-body' => 'Hello!
9092

Status & tagging log