r87726 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87725‎ | r87726 | r87727 >
Date:15:56, 9 May 2011
Author:maxsem
Status:ok
Tags:
Comment:
Use runChild() to pass useful stuff like quiet mode
Modified paths:
  • /trunk/phase3/includes/installer/DatabaseUpdater.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/DatabaseUpdater.php
@@ -524,7 +524,7 @@
525525 "Populating log_user_text field, printing progress markers. For large\n" .
526526 "databases, you may want to hit Ctrl-C and do this manually with\n" .
527527 "maintenance/populateLogUsertext.php.\n" );
528 - $task = new PopulateLogUsertext();
 528+ $task = $this->maintenance->runChild( 'PopulateLogUsertext' );
529529 $task->execute();
530530 $this->output( "Done populating log_user_text field.\n" );
531531 }
@@ -539,7 +539,7 @@
540540 "Populating log_search table, printing progress markers. For large\n" .
541541 "databases, you may want to hit Ctrl-C and do this manually with\n" .
542542 "maintenance/populateLogSearch.php.\n" );
543 - $task = new PopulateLogSearch();
 543+ $task = $this->maintenance->runChild( 'PopulateLogSearch' );
544544 $task->execute();
545545 $this->output( "Done populating log_search table.\n" );
546546 }
@@ -567,7 +567,7 @@
568568 return;
569569 }
570570
571 - $task = new UpdateCollation();
 571+ $task = $this->maintenance->runChild( 'UpdateCollation' );
572572 $task->execute();
573573 }
574574 }

Status & tagging log