r87718 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87717‎ | r87718 | r87719 >
Date:14:48, 9 May 2011
Author:catrope
Status:ok
Tags:
Comment:
ArticleFeedback: Fix escaping in r87310, r87522
Modified paths:
  • /trunk/extensions/ArticleFeedback/SpecialArticleFeedback.php (modified) (history)
  • /trunk/extensions/ArticleFeedback/populateAFStatistics.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/SpecialArticleFeedback.php
@@ -261,9 +261,9 @@
262262 'afshl_avg_overall',
263263 'afshl_avg_ratings'
264264 ),
265 - array( 'afshl_ts = ' . $row->afshl_ts),
 265+ array( 'afshl_ts' => $row->afshl_ts ),
266266 __METHOD__,
267 - array( "ORDER BY" => "afshl_avg_overall" )
 267+ array( "ORDER BY" => "afshl_avg_overall" ) // FIXME unindexed
268268 );
269269 $highs_lows = $this->buildHighsAndLows( $result );
270270 $wgMemc->set( $key, $highs_lows, 86400 );
Index: trunk/extensions/ArticleFeedback/populateAFStatistics.php
@@ -71,7 +71,7 @@
7272 'aa_rating_value',
7373 'aa_rating_id'
7474 ),
75 - array( 'aa_timestamp >= ' . $this->getLowerBoundTimestamp() ),
 75+ array( 'aa_timestamp >= ' . $this->dbr->addQuotes( $this->getLowerBoundTimestamp() ) ),
7676 __METHOD__,
7777 array() // better to do with limits and offsets?
7878 );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87310Adding sql to create table for article feedback stats relating to high/low ar...awjrichards01:19, 3 May 2011
r87522Followup r87402, r87381, r87379...awjrichards00:14, 6 May 2011

Status & tagging log