r87675 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87674‎ | r87675 | r87676 >
Date:06:17, 8 May 2011
Author:dantman
Status:deferred
Tags:
Comment:
Use the DummyLinker in 1.18 when it exists, non-static calls to Linker itself isn't really supported anymore.
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_Infolink.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_QueryPrinter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/SMW_Infolink.php
@@ -326,7 +326,7 @@
327327 */
328328 protected function getLinker( &$linker = null ) {
329329 if ( $linker === null ) {
330 - $linker = new Linker();
 330+ $linker = class_exists('DummyLinker') ? new DummyLinker : new Linker;
331331 }
332332 return $linker;
333333 }
@@ -476,4 +476,4 @@
477477 return $result;
478478 }
479479
480 -}
\ No newline at end of file
 480+}
Index: trunk/extensions/SemanticMediaWiki/includes/SMW_QueryPrinter.php
@@ -112,7 +112,7 @@
113113 $this->mInline = $inline;
114114 $this->mLinkFirst = ( $smwgQDefaultLinking != 'none' );
115115 $this->mLinkOthers = ( $smwgQDefaultLinking == 'all' );
116 - $this->mLinker = new Linker(); ///TODO: how can we get the default or user skin here (depending on context)?
 116+ $this->mLinker = class_exists('DummyLinker') ? new DummyLinker : new Linker; ///TODO: how can we get the default or user skin here (depending on context)?
117117 $this->useValidator = $useValidator;
118118 }
119119
@@ -626,4 +626,4 @@
627627 return $params;
628628 }
629629
630 -}
\ No newline at end of file
 630+}

Status & tagging log