r8761 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r8760‎ | r8761 | r8762 >
Date:09:02, 30 April 2005
Author:timstarling
Status:old
Tags:
Comment:
formatting
Modified paths:
  • /branches/REL1_4/phase3/includes/SpecialUnusedimages.php (modified) (history)

Diff [purge]

Index: branches/REL1_4/phase3/includes/SpecialUnusedimages.php
@@ -29,16 +29,16 @@
3030 if ( $wgCountCategorizedImagesAsUsed ) {
3131 extract( $dbr->tableNames( 'cur', 'image', 'imagelinks', 'categorylinks' ) );
3232
33 - return 'SELECT img_name as title, img_user, img_user_text, img_timestamp as value, img_description
34 - FROM ((('.$cur.' AS I LEFT JOIN '.$categorylinks.' AS L ON I.cur_id = L.cl_from)
35 - LEFT JOIN '.$imagelinks.' AS P ON I.cur_title = P.il_to)
36 - INNER JOIN '.$image.' AS G ON I.cur_title = G.img_name)
37 - WHERE I.cur_namespace = '.NS_IMAGE.' AND L.cl_from IS NULL AND P.il_to IS NULL';
 33+ return "SELECT img_name as title, img_user, img_user_text, img_timestamp as value, img_description " .
 34+ "FROM ((($cur AS I LEFT JOIN $categorylinks AS L ON I.cur_id = L.cl_from) " .
 35+ "LEFT JOIN $imagelinks AS P ON I.cur_title = P.il_to) " .
 36+ "INNER JOIN $image AS G ON I.cur_title = G.img_name) " .
 37+ "WHERE I.cur_namespace = ".NS_IMAGE." AND L.cl_from IS NULL AND P.il_to IS NULL";
3838 } else {
3939 extract( $dbr->tableNames( 'image','imagelinks' ) );
4040
41 - return 'SELECT img_name as title, img_user, img_user_text, img_timestamp as value, img_description' .
42 - ' FROM '.$image.' LEFT JOIN '.$imagelinks.' ON img_name=il_to WHERE il_to IS NULL ';
 41+ return "SELECT img_name as title, img_user, img_user_text, img_timestamp as value, img_description" .
 42+ " FROM $image LEFT JOIN $imagelinks ON img_name=il_to WHERE il_to IS NULL ";
4343 }
4444 }
4545

Status & tagging log