r8759 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r8758‎ | r8759 | r8760 >
Date:08:26, 30 April 2005
Author:eloquence
Status:old
Tags:
Comment:
use <base href=""> instead of doing silly URL substitutions
Modified paths:
  • /trunk/extensions/ee/ee.pl (modified) (history)

Diff [purge]

Index: trunk/extensions/ee/ee.pl
@@ -345,8 +345,8 @@
346346 ]);
347347 open(PREVIEW,">$tempdir/preview.html");
348348 $preview=$response->content;
349 - # Replace relative URLs with absolute ones
350 - $preview=~s|$path|$server$path|gi;
 349+ # Replace relative URLs with absolute ones
 350+ $preview=~s|<head>|<head>\n <base href="$server$path">|gi;
351351 print PREVIEW $preview;
352352 close(PREVIEW);
353353 if($previewclient) {

Status & tagging log