r8754 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r8753‎ | r8754 | r8755 >
Date:02:52, 30 April 2005
Author:vibber
Status:old
Tags:
Comment:
Move image TOC into content area; a float tends to overlap and crunch in
ugly ways when the title is long or the window is small.
The markup of the toc itself is still a bit odd (table, may conflict with
wiki toc if the description includes one).
Modified paths:
  • /trunk/phase3/includes/ImagePage.php (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/main.css
——@@ -1144,7 +1144,6 @@
11451145 text-indent: -2em;
11461146 }
11471147
1148 -div.imagepagetoc {
1149 - float: right;
1150 - margin-top: -4em;
 1148+div.imagepagetoc table {
 1149+ margin-bottom: 1em;
11511150 }
Index: trunk/phase3/includes/ImagePage.php
——@@ -61,7 +61,7 @@
6262 $r .= '<a href="#imghistory">' . wfMsg( 'imghistory' ) . '</a href> - ';
6363 $r .= '<a href="#imagelinks">' . wfMsg( 'imagelinks' ) . '</a href>';
6464 if ( $wgShowEXIF ) {
65 - $r .= ' - <a href="#showexif">' . wfMsg( 'exifdata' ) . '</a>';
 65+ $r .= ' - <a href="#exifdata">' . wfMsg( 'exifdata' ) . '</a>';
6666 }
6767
6868

Status & tagging log