| Index: trunk/extensions/SemanticResultFormats/Timeline/SRF_Timeline.php |
| — | — | @@ -175,7 +175,7 @@ |
| 176 | 176 | while ( ( $object = efSRFGetNextDV( $field ) ) !== false ) { // Loop over property values |
| 177 | 177 | $event = $this->handlePropertyValue( |
| 178 | 178 | $object, $outputmode, $pr, $first_col, $hastitle, $hastime, |
| 179 | | - $first_value, $isEventline, $curmeta, $curdata, $date_value, $output |
| | 179 | + $first_value, $isEventline, $curmeta, $curdata, $date_value, $output, $positions |
| 180 | 180 | ); |
| 181 | 181 | if ( $event !== false ) { |
| 182 | 182 | $events[] = $event; |
| — | — | @@ -236,6 +236,8 @@ |
| 237 | 237 | /** |
| 238 | 238 | * Hanldes a single property value. Returns an array with data for a single event or false. |
| 239 | 239 | * |
| | 240 | + * FIXME: 13 arguments, of which a whole bunch are byref... not a good design :) |
| | 241 | + * |
| 240 | 242 | * @since 1.5.3 |
| 241 | 243 | * |
| 242 | 244 | * @param SMWDataValue $object |
| — | — | @@ -250,11 +252,12 @@ |
| 251 | 253 | * @param string &$curdata |
| 252 | 254 | * @param &$date_value |
| 253 | 255 | * @param boolean &$output |
| | 256 | + * @param array &$positions |
| 254 | 257 | * |
| 255 | 258 | * @return false or array |
| 256 | 259 | */ |
| 257 | 260 | protected function handlePropertyValue( SMWDataValue $object, $outputmode, SMWPrintRequest $pr, $first_col, |
| 258 | | - &$hastitle, &$hastime, $first_value, $isEventline, &$curmeta, &$curdata, $date_value, &$output ) { |
| | 261 | + &$hastitle, &$hastime, $first_value, $isEventline, &$curmeta, &$curdata, $date_value, &$output, array &$positions ) { |
| 259 | 262 | |
| 260 | 263 | $event = false; |
| 261 | 264 | |