r87477 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87476‎ | r87477 | r87478 >
Date:02:55, 5 May 2011
Author:tstarling
Status:ok
Tags:
Comment:
Fixed some register_globals vulnerabilities.
Modified paths:
  • /trunk/extensions/Cassandra/Cassandra_body.php (modified) (history)
  • /trunk/extensions/Cassandra/lib/Cassandra.php (modified) (history)
  • /trunk/extensions/Cassandra/lib/cassandra_constants.php (modified) (history)
  • /trunk/extensions/Cassandra/lib/cassandra_types.php (modified) (history)
  • /trunk/extensions/FirefoggChunkedUpload/tests/UploadFromChunksTest.php (modified) (history)
  • /trunk/extensions/HtmlUi/templates/HtmlUiFieldset.php (modified) (history)
  • /trunk/extensions/HtmlUi/templates/HtmlUiForm.php (modified) (history)
  • /trunk/extensions/ParserFunctions/ParserFunctions.i18n.magic.php (modified) (history)
  • /trunk/extensions/TimedMediaHandler/tests/phpunit/ApiTestCaseVideoUpload.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FirefoggChunkedUpload/tests/UploadFromChunksTest.php
@@ -1,4 +1,7 @@
22 <?php
 3+if ( !defined( 'MEDIAWIKI' ) ) {
 4+ exit;
 5+}
36
47 global $IP;
58 require_once( "$IP/maintenance/tests/ApiSetup.php" );
Index: trunk/extensions/TimedMediaHandler/tests/phpunit/ApiTestCaseVideoUpload.php
@@ -4,6 +4,10 @@
55 * @author dale
66 */
77
 8+if ( !defined( 'MEDIAWIKI' ) ) {
 9+ exit;
 10+}
 11+
812 // Include core class ApiTestCaseUpload ( not part of base autoLoader )
913 global $IP;
1014 require_once( "$IP/tests/phpunit/includes/api/ApiTestCaseUpload.php" );
Index: trunk/extensions/Cassandra/Cassandra_body.php
@@ -1,4 +1,7 @@
22 <?php
 3+if ( !defined( 'MEDIAWIKI' ) ) {
 4+ exit;
 5+}
36
47 global $wgThriftRoot, $wgAutoloadClasses;
58 $GLOBALS['THRIFT_ROOT'] = $wgThriftRoot;
@@ -115,4 +118,4 @@
116119 . "\n\nStack trace: " . $e->getTraceAsString()
117120 );
118121 }
119 -}
\ No newline at end of file
 122+}
Index: trunk/extensions/Cassandra/lib/cassandra_constants.php
@@ -1,4 +1,7 @@
22 <?php
 3+if ( !defined( 'MEDIAWIKI' ) ) {
 4+ exit;
 5+}
36 /**
47 * Autogenerated by Thrift
58 *
@@ -10,4 +13,4 @@
1114
1215 $GLOBALS['cassandra_CONSTANTS']['VERSION'] = "0.5.1";
1316
14 -?>
\ No newline at end of file
 17+?>
Index: trunk/extensions/Cassandra/lib/Cassandra.php
@@ -1,4 +1,8 @@
22 <?php
 3+if ( !defined( 'MEDIAWIKI' ) ) {
 4+ exit;
 5+}
 6+
37 /**
48 * Autogenerated by Thrift
59 *
@@ -4584,4 +4588,4 @@
45854589
45864590 }
45874591
4588 -?>
\ No newline at end of file
 4592+?>
Index: trunk/extensions/Cassandra/lib/cassandra_types.php
@@ -1,4 +1,7 @@
22 <?php
 3+if ( !defined( 'MEDIAWIKI' ) ) {
 4+ exit;
 5+}
36 /**
47 * Autogenerated by Thrift
58 *
@@ -1168,4 +1171,4 @@
11691172
11701173 }
11711174
1172 -?>
\ No newline at end of file
 1175+?>
Index: trunk/extensions/ParserFunctions/ParserFunctions.i18n.magic.php
@@ -436,4 +436,4 @@
437437 'ifexist' => array( 0, 'עקזיסט', 'קיים' ),
438438 'time' => array( 0, 'צייט', 'זמן' ),
439439 'timel' => array( 0, 'צייטל', 'זמןמ' ),
440 -);
\ No newline at end of file
 440+);
Index: trunk/extensions/HtmlUi/templates/HtmlUiFieldset.php
@@ -1,3 +1,4 @@
 2+<?php if ( !defined( 'MEDIAWIKI' ) ) exit; ?>
23 <fieldset class="htmlUiFieldset" rel="<?php echo $id ?>">
34 <?php foreach( $elements as $element ): ?>
45 <?php echo $element->render(); ?>
Index: trunk/extensions/HtmlUi/templates/HtmlUiForm.php
@@ -1,3 +1,4 @@
 2+<?php if ( !defined( 'MEDIAWIKI' ) ) exit; ?>
23 <form class="htmlUiForm"<?php self::attributes( $attributes ) ?>>
34 <?php foreach( $elements as $element ): ?>
45 <?php echo $element->render(); ?>

Status & tagging log