r87430 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87429‎ | r87430 | r87431 >
Date:18:40, 4 May 2011
Author:awjrichards
Status:ok
Tags:
Comment:
Checking if cache object is instance of ResultsWrapper, per suggestion from TrevorParscal
Modified paths:
  • /trunk/extensions/ArticleFeedback/SpecialArticleFeedback.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/SpecialArticleFeedback.php
@@ -220,7 +220,7 @@
221221 // check if we've got results in the cache
222222 $key = wfMemcKey( 'article_feedback_stats_highs_lows' );
223223 $cache = $wgMemc->get( $key );
224 - if ( $cache ) {
 224+ if ( $cache instanceof ResultsWrapper ) {
225225 $result = $cache;
226226 } else {
227227 $dbr = wfGetDB( DB_SLAVE );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87424Moved create index for ts on article feedback to it's own file; Added apporpr...awjrichards18:21, 4 May 2011
r87425Re-fixed comparisson of cache data - now actually checking to see if it doesn...awjrichards18:26, 4 May 2011
r87429Altering how we check for results in cache - now just checking if does not e...awjrichards18:37, 4 May 2011

Status & tagging log