r87427 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87426‎ | r87427 | r87428 >
Date:18:34, 4 May 2011
Author:nelson
Status:ok
Tags:
Comment:
No current need for an alias to getPath()
Modified paths:
  • /trunk/extensions/Push/api/ApiPushImages.php (modified) (history)
  • /trunk/extensions/TimedMediaHandler/WebVideoTranscode/WebVideoTranscodeJob.php (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/WebVideoTranscode/WebVideoTranscodeJob.php
@@ -31,7 +31,7 @@
3232 // Get the file object
3333 $file = wfLocalFile( $this->title );
3434
35 - $source = $file->getFullPath();
 35+ $source = $file->getPath();
3636 if( !is_file($source ) ){
3737 $this->output( 'File not found: ' . $this->title );
3838 return false;
@@ -176,7 +176,7 @@
177177 function ffmpegEncode( $file, $target, $options, $pass=0 ){
178178 global $wgFFmpegLocation;
179179 // Get the source
180 - $source = $file->getFullPath();
 180+ $source = $file->getPath();
181181 $this->output( "Encode:\n source:$source\n target:$target\n" );
182182
183183 // Set up the base command
@@ -336,7 +336,7 @@
337337 global $wgFFmpeg2theoraLocation;
338338
339339 // Get the source:
340 - $source = $file->getFullPath();
 340+ $source = $file->getPath();
341341
342342 // Set up the base command
343343 $cmd = wfEscapeShellArg( $wgFFmpeg2theoraLocation ) . ' ' . wfEscapeShellArg( $source );
@@ -419,4 +419,4 @@
420420 'contact' => "--contact"
421421 );
422422
423 -}
\ No newline at end of file
 423+}
Index: trunk/extensions/Push/api/ApiPushImages.php
@@ -256,7 +256,7 @@
257257 );
258258
259259 if ( $egPushDirectFileUploads ) {
260 - $requestData['file'] = '@' . $imagePage->getFile()->getFullPath();
 260+ $requestData['file'] = '@' . $imagePage->getFile()->getPath();
261261 }
262262 else {
263263 $requestData['url'] = $imagePage->getDisplayedFile()->getFullUrl();

Status & tagging log