r87380 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r87379‎ | r87380 | r87381 >
Date:01:43, 4 May 2011
Author:demon
Status:ok (Comments)
Tags:
Comment:
Add hack to shut up fatals when getCategories() is called without an actual OutputPage
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
——@@ -607,6 +607,10 @@
608608 * the ->getCategories( $out ) form with whatout OutputPage is on hand
609609 */
610610 function getCategories( OutputPage $out=null ) {
 611+ if( !$out ) {
 612+ global $wgOut;
 613+ $out = $wgOut;
 614+ }
611615
612616 $catlinks = $this->getCategoryLinks( $out );
613617

Follow-up revisions

RevisionCommit summaryAuthorDate
r87382Add proper $out setting to Skin::getCategories which is present in the other ...dantman01:53, 4 May 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   18:40, 7 June 2011

Further cleaned up in r87389

Status & tagging log