r87277 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87276‎ | r87277 | r87278 >
Date:18:48, 2 May 2011
Author:nelson
Status:ok
Tags:
Comment:
Fix and add some comments.
Modified paths:
  • /trunk/phase3/includes/filerepo/LocalFile.php (modified) (history)
  • /trunk/phase3/includes/filerepo/OldLocalFile.php (modified) (history)
  • /trunk/phase3/thumb.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/OldLocalFile.php
@@ -1,6 +1,6 @@
22 <?php
33 /**
4 - * Old file in the in the oldimage table
 4+ * Old file in the oldimage table
55 *
66 * @file
77 * @ingroup FileRepo
Index: trunk/phase3/includes/filerepo/LocalFile.php
@@ -33,7 +33,7 @@
3434 * @private
3535 */
3636 var
37 - $fileExists, # does the file file exist on disk? (loadFromXxx)
 37+ $fileExists, # does the file exist on disk? (loadFromXxx)
3838 $historyLine, # Number of line to return by nextHistoryLine() (constructor)
3939 $historyRes, # result of the query for the file's history (nextHistoryLine)
4040 $width, # \
@@ -549,8 +549,8 @@
550550 /** isTrustedFile inherited */
551551
552552 /**
553 - * Returns true if the file file exists on disk.
554 - * @return boolean Whether file file exist on disk.
 553+ * Returns true if the file exists on disk.
 554+ * @return boolean Whether file exist on disk.
555555 */
556556 public function exists() {
557557 $this->load();
Index: trunk/phase3/thumb.php
@@ -41,7 +41,7 @@
4242 if ( isset( $params['p'] ) ) {
4343 $params['page'] = $params['p'];
4444 }
45 - unset( $params['r'] );
 45+ unset( $params['r'] ); // ignore 'r' because we unconditionally pass File::RENDER
4646
4747 // Is this a thumb of an archived file?
4848 $isOld = (isset( $params['archived'] ) && $params['archived']);

Status & tagging log