r87270 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87269‎ | r87270 | r87271 >
Date:18:27, 2 May 2011
Author:reedy
Status:ok
Tags:
Comment:
Update PHP minimum version checks to 5.2.3
Modified paths:
  • /branches/REL1_17/phase3/maintenance/Maintenance.php (modified) (history)
  • /branches/REL1_17/phase3/maintenance/update.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/maintenance/update.php
@@ -10,8 +10,8 @@
1111 * @ingroup Maintenance
1212 */
1313
14 -if ( !function_exists( 'version_compare' ) || ( version_compare( phpversion(), '5.1.0' ) < 0 ) ) {
15 - echo "You are using PHP version " . phpversion() . " but MediaWiki needs PHP 5.1.0 or higher. ABORTING.\n" .
 14+if ( !function_exists( 'version_compare' ) || ( version_compare( phpversion(), '5.2.3' ) < 0 ) ) {
 15+ echo "You are using PHP version " . phpversion() . " but MediaWiki needs PHP 5.2.3 or higher. ABORTING.\n" .
1616 "Check if you have a newer php executable with a different name, such as php5.\n";
1717 die( 1 );
1818 }
Index: branches/REL1_17/phase3/maintenance/Maintenance.php
@@ -12,10 +12,10 @@
1313 $maintClass = false;
1414
1515 // Make sure we're on PHP5 or better
16 -if ( version_compare( PHP_VERSION, '5.1.0' ) < 0 ) {
17 - die ( "Sorry! This version of MediaWiki requires PHP 5.1.x; you are running " .
 16+if ( version_compare( PHP_VERSION, '5.2.3' ) < 0 ) {
 17+ die ( "Sorry! This version of MediaWiki requires PHP 5.2.3; you are running " .
1818 PHP_VERSION . ".\n\n" .
19 - "If you are sure you already have PHP 5.1.x or higher installed, it may be\n" .
 19+ "If you are sure you already have PHP 5.2.3 or higher installed, it may be\n" .
2020 "installed in a different path from PHP " . PHP_VERSION . ". Check with your system\n" .
2121 "administrator.\n" );
2222 }

Status & tagging log