r87250 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87249‎ | r87250 | r87251 >
Date:15:32, 2 May 2011
Author:ialex
Status:ok
Tags:
Comment:
Moved Skin::$mWatchLinkNum to SkinLegacy since it's only used there and made it protected per documentation (nothing else apart SkinLegacy uses it)
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/includes/SkinLegacy.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinLegacy.php
@@ -9,6 +9,7 @@
1010
1111 class SkinLegacy extends SkinTemplate {
1212 var $useHeadElement = true;
 13+ protected $mWatchLinkNum = 0; // Appended to end of watch link id's
1314
1415 /**
1516 * Add skin specific stylesheets
Index: trunk/phase3/includes/Skin.php
@@ -16,11 +16,6 @@
1717 * @ingroup Skins
1818 */
1919 abstract class Skin {
20 - /**#@+
21 - * @private
22 - */
23 - var $mWatchLinkNum = 0; // Appended to end of watch link id's
24 - /**#@-*/
2520 protected $skinname = 'standard';
2621 protected $mRelevantTitle = null;
2722 protected $mRelevantUser = null;

Status & tagging log