r87237 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87236‎ | r87237 | r87238 >
Date:06:13, 2 May 2011
Author:aaron
Status:ok
Tags:
Comment:
* (bug 24955) account page says "biography will be set as default userpage" even though $wgMakeUserPageFromBio=false
* Other small msg cleanups
Modified paths:
  • /trunk/extensions/ConfirmAccount/ConfirmAccount.i18n.php (modified) (history)
  • /trunk/extensions/ConfirmAccount/RequestAccount_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfirmAccount/RequestAccount_body.php
@@ -78,8 +78,9 @@
7979 }
8080
8181 protected function showForm( $msg = '', $forgotFile = 0 ) {
82 - global $wgOut, $wgUser, $wgUseRealNamesOnly, $wgAllowRealName, $wgAccountRequestToS,
83 - $wgAccountRequestTypes, $wgAccountRequestExtraInfo, $wgAllowAccountRequestFiles;
 82+ global $wgOut, $wgUser, $wgUseRealNamesOnly, $wgAllowRealName;
 83+ global $wgAccountRequestToS, $wgAccountRequestTypes, $wgAccountRequestExtraInfo,
 84+ $wgAllowAccountRequestFiles, $wgMakeUserPageFromBio;
8485
8586 $this->mForgotAttachment = $forgotFile;
8687
@@ -153,7 +154,11 @@
154155
155156 $form .= '<fieldset>';
156157 $form .= '<legend>' . wfMsgHtml( 'requestaccount-leg-person' ) . '</legend>';
157 - $form .= wfMsgExt( 'requestaccount-bio-text', array( 'parse' ) ) . "\n";
 158+ if ( $wgMakeUserPageFromBio ) {
 159+ $form .= wfMsgExt( 'requestaccount-bio-text-i', 'parse' ) . "\n";
 160+ }
 161+ $form .= wfMsgExt( 'requestaccount-bio-text', 'parse' ) . "\n";
 162+
158163 if ( $wgUseRealNamesOnly || $wgAllowRealName ) {
159164 $form .= '<table cellpadding=\'4\'>';
160165 $form .= "<tr><td>" . Xml::label( wfMsgHtml( 'requestaccount-real' ), 'wpRealName' ) . "</td>";
Index: trunk/extensions/ConfirmAccount/ConfirmAccount.i18n.php
@@ -27,25 +27,24 @@
2828 'requestaccount-acc-text' => 'Your e-mail address will be sent a confirmation message once this request is submitted.
2929 Please respond by clicking on the confirmation link provided by the e-mail.
3030 Also, your password will be e-mailed to you when your account is created.',
31 - 'requestaccount-areas' => '', # Do not translate this message to other languages
 31+ 'requestaccount-areas' => '', # Do not translate this message to other languages
3232 'requestaccount-areas-text' => 'Select the topic areas below in which you have formal expertise or would like to do the most work in.',
3333 'requestaccount-ext-text' => 'The following information is kept private and will only be used for this request.
3434 You may want to list contacts such a phone number to aid in identify confirmation.',
35 - 'requestaccount-bio-text' => "Your biography will be set as the default content for your userpage.
36 -Try to include any credentials.
37 -Make sure you are comfortable publishing such information.
38 -Your name can be changed via [[Special:Preferences|your preferences]].",
 35+ 'requestaccount-bio-text' => "Try to include any relevant credentials in your biography below.",
 36+ 'requestaccount-bio-text-i' => "'''Your biography will be set as the initial content for your userpage.'''
 37+Make sure you are comfortable publishing such information.",
3938 'requestaccount-real' => 'Real name:',
40 - 'requestaccount-same' => '(same as real name)',
 39+ 'requestaccount-same' => '(same as real name below)',
4140 'requestaccount-email' => 'E-mail address:',
4241 'requestaccount-reqtype' => 'Position:',
4342 'requestaccount-level-0' => 'author',
4443 'requestaccount-level-1' => 'editor',
4544 'requestaccount-info' => '(?)',
46 - 'requestaccount-bio' => 'Personal biography:',
 45+ 'requestaccount-bio' => 'Personal biography (plain text only):',
4746 'requestaccount-attach' => 'Resume or CV (optional):',
4847 'requestaccount-notes' => 'Additional notes:',
49 - 'requestaccount-urls' => 'List of websites, if any (separate with newlines):',
 48+ 'requestaccount-urls' => 'List of websites, if any (each on a separate line):',
5049 'requestaccount-agree' => 'You must certify that your real name is correct and that you agree to our Terms of Service.',
5150 'requestaccount-inuse' => 'Username is already in use in a pending account request.',
5251 'requestaccount-tooshort' => 'Your biography must be at least $1 {{PLURAL:$1|word|words}} long.',

Status & tagging log